Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ADF-1811/group-conditions-logic #605

Open
wants to merge 5 commits into
base: feat/HKD-6/integration
Choose a base branch
from

Conversation

shaveko
Copy link
Contributor

@shaveko shaveko commented Oct 23, 2024

related to https://oat-sa.atlassian.net/browse/ADF-1811

  • ⚠️ Release and add to tao-core dependencies

Description

For list advancedSearch criteria search logic has to be implemented to allow user to

  • Conjunct selected list items in search (logical and), say we want to select entities which has value1 and value2 and ... valueN in a list property
  • Disjunct selected list items in search (logical or) to select entities having either value1 or value2 or ... valueN in a list property
  • Negation of disjunction to select entities having neither value1 nor value2 nor ... valueN in a list property

How to test

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants