Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tr 5782/dry run items #373

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

gabrielfs7
Copy link
Contributor

@gabrielfs7 gabrielfs7 commented Oct 4, 2023

https://oat-sa.atlassian.net/browse/TR-5782
https://oat-sa.atlassian.net/browse/RFE-544

Goal

I've needed to create new methods because:

  1. I needed to use the behavior of those methods outside and they are protected.
  2. I did not want to change the visibility of the current methods (that are protected) as I would have to change all the places inheriting those methods and therefore avoiding breaking changes.
  3. I am not sure that their behavior will be the only behavior needed in the future and I would not like to make the existing methods logic (internal) to be affected by this.

Related PRs

@gabrielfs7 gabrielfs7 changed the base branch from master to develop October 4, 2023 09:41
Copy link
Contributor

@kilatib kilatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the reason in that method they do nothing, why we just not use them directly?

P.S.> Copyright (c) not updated

@gabrielfs7
Copy link
Contributor Author

gabrielfs7 commented Oct 5, 2023

What the reason in that method they do nothing, why we just not use them directly?

P.S.> Copyright (c) not updated

Thanks @kilatib !

To answer your question, there are 3 reasons I've created new methods.

  1. I needed to use the behavior of those methods outside and they are protected.
  2. I did not want to change the visibility of the current methods (that are protected) as I would have to change all the places inheriting those methods and therefore avoiding breaking changes.
  3. I am not sure that their behavior will be the only behavior needed in the future and I would not like to make the existing methods logic (internal) to be affected by this.

Copy link
Contributor

@kilatib kilatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielfs7 gabrielfs7 merged commit f773789 into develop Oct 9, 2023
3 checks passed
@gabrielfs7 gabrielfs7 deleted the feat/TR-5782/dry-run-items branch October 9, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants