feat: twig tags for feedback modals

[bartlomiejmarszal]

Provide twig oriented feedback blocks rendering

[bugalot]

From my perspective, and not change the behavior of QTI-SDK, in case you simply wish to use Twig instead of the regular PHP template oriented notation (<?php if: ?> and co.), is to augment the MarkupPostRenderer::render() method to make it Twig capable. It shoudln't be a big deal.

This would cover all the scenarios, using Twig, or the current implementation.

[pribi]

I propose to clear up the naming a bit. If I understand it correctly:

Does this mean if twig feedback component must be used? I propose to rename to:
if ($this->mustUseTwigFeedbackComponent($component) === true) { ... }

and set twig feedback component:
$this->setTwigFeedbackComponent($component, $rendering);

[bartlomiejmarszal]

From my perspective, and not change the behavior of QTI-SDK, in case you simply wish to use Twig instead of the regular PHP template oriented notation (<?php if: ?> and co.), is to augment the MarkupPostRenderer::render() method to make it Twig capable. It shoudln't be a big deal.

This would cover all the scenarios, using Twig, or the current implementation.

Hey! Thank you for your comment. For me, it is not clear the reason behind using two different renderers. I saw a way how I could generate <!-- qtism-if --!> notation. The result of this is following:

<!-- qtism-if (($qtismState['PASS_CATEGORY_SCORED_RENDERING'] !== null && ($qtismState['PASS_CATEGORY_SCORED_RENDERING'] instanceof qtism\\common\\datatypes\\QtiIdentifier && $qtismState['PASS_CATEGORY_SCORED_RENDERING']->equals(new qtism\\common\\datatypes\\QtiIdentifier('not_passed')) || $qtismState['PASS_CATEGORY_SCORED_RENDERING'] instanceof qtism\\runtime\\common\\Container && $qtismState['PASS_CATEGORY_SCORED_RENDERING']->contains(new qtism\\common\\datatypes\\QtiIdentifier('not_passed'))))): -->

This should be replaced in MarkupPostRenderer with twig as a new feature. I saw this process should be done by regexp operations. But I do not understand this approach. Why do I need to complicate this like that? Why I can't just generate the correct markup when required (based on FeedbackShowHidePolicy)?