Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tests subdirectory #858

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

remove tests subdirectory #858

wants to merge 13 commits into from

Conversation

chrisphpgarcia
Copy link
Contributor

No description provided.

@bugalot bugalot self-requested a review June 12, 2017 12:16
bugalot
bugalot requested changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@bugalot bugalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Pull Request does work with a wide range of tests.

The following process cannot be achieved with this PR.

  1. Download test https://github.com/oat-sa/extension-tao-testqti/blob/master/test/samples/archives/QTI%202.1/rubrics/RubricBlocksStylesheetsImages.zip.

  2. Import the test as QTI 2.1.

  3. Run the test in old/new test runner, everything fine.

  4. Export the test as QTI 2.1

  5. Re-import the test as QTI 2.1 -> It fails to import.

It worked perfectly in previous versions.

Thanks for making the appropriate changes.

bugalot
bugalot requested changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@bugalot bugalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the same behaviour after updating your changes. No way to export/import the package I reported in my last review.

bugalot
bugalot requested changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@bugalot bugalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, by reproducing the scenario described in the first PR review, the test cannot be compiled as a delivery. It breaks because paths from test.xml to assets (stylesheets and images) are broken after export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugalot bugalot bugalot requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@bugalot bugalot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisphpgarcia @bugalot