Hardcoded compilation to version 2.2. #1901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-sebire
requested review from
bugalot,
roman-kovalev,
mike-ionut-mihai-sandu-tao and
siwane
mike-ionut-mihai-sandu-tao
requested changes
Aug 19, 2020
| @@ -476,7 +476,7 @@ protected function compactTest() | |||
| $resolver = new taoQtiTest_helpers_ItemResolver(Service::singleton()); | |||
| $originalDoc = $testService->getDoc($test); | |||
|
|
|||
| $compiledDoc = XmlCompactDocument::createFromXmlAssessmentTestDocument($originalDoc, $resolver, $resolver); | |||
| $compiledDoc = XmlCompactDocument::createFromXmlAssessmentTestDocument($originalDoc, $resolver, $resolver, '2.2'); | |||
There was a problem hiding this comment.
i would go for a constant that will describe the new added value
|
also please update the test in such way it will reflect the change |
I added tests for the branching, precondition and linearity for new versions of QTI Compact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows test compilation to QTI Compact 2.2.
Thorough tests have been done on the branch itself, along with the counterpart in extension-tao-itemqti.
This PR requires oat-sa/extension-tao-itemqti#1516