Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aut 2939 #470

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feature/aut 2939 #470

wants to merge 10 commits into from

Conversation

albertosgz
Copy link
Contributor

@albertosgz albertosgz commented May 26, 2023

Fixes AUT-2939

What's changed

A list of RTL languages is available on right side of panel while authoring a passage, and text is displayed on the right when one is picked up.

@albertosgz
Copy link
Contributor Author

This PR is needed oat-sa/extension-tao-itemqti#2367

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #470 (2cf5987) into develop (17c0330) will increase coverage by 1.11%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop     #470      +/-   ##
=============================================
+ Coverage      33.15%   34.27%   +1.11%     
- Complexity       768      771       +3     
=============================================
  Files             98       93       -5     
  Lines           2856     2792      -64     
=============================================
+ Hits             947      957      +10     
+ Misses          1909     1835      -74     
Impacted Files Coverage Δ
...l/sharedStimulus/parser/JsonQtiAttributeParser.php 82.35% <60.00%> (-5.46%) ⬇️

... and 24 files with indirect coverage changes

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

model/sharedStimulus/parser/JsonQtiAttributeParser.php Outdated Show resolved Hide resolved
views/scss/media.scss Outdated Show resolved Hide resolved
views/js/qtiXmlRenderer/renderers/Item.js Outdated Show resolved Hide resolved
views/js/qtiCreator/widgets/item/states/Active.js Outdated Show resolved Hide resolved
@github-actions
Copy link

Version

Target Version 12.36.0
Last version 12.35.0

There are 0 BREAKING CHANGE, 10 features, 0 fix

Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants