Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve opening another tab with new session with the same user #387

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

tikhanovichA
Copy link
Contributor

@tikhanovichA tikhanovichA commented Apr 11, 2024

https://oat-sa.atlassian.net/browse/INF-266

Depends on oat-sa/extension-tao-testqti#2456

For cases when one of sessions was finished and then reopened the pausing for another tabs worked not like expected.

How to test:

  1. Start new test A (new LTI link)
  2. Start new test B (new LTI link)
  3. A gets the “concurrent test” popup. Do not click on it
  4. Finish test B
  5. Check that you have “Thank you” page
  6. Go back to test A & Accept the popup
  7. Check that you have “Test suspended” page
  8. Start the previous test A again (reusing the previous LTI link). This unpauses A
  9. Start the previous test B again (reusing the previous LTI link). This pauses A
  10. Go back to test A & Accept the popup
  11. You should receive the “Test suspended” page
Screen.Recording.2024-04-12.at.08.59.03.mov

Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tikhanovichA

Only code check, I cannot test the feature locally, but it must be covered by QA

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

Version

Target Version 12.21.2
Last version 12.21.1

There are 0 BREAKING CHANGE, 0 feature, 8 fixes

@tikhanovichA tikhanovichA merged commit d9c6d44 into develop Apr 23, 2024
4 of 5 checks passed
@tikhanovichA tikhanovichA deleted the fix/INF-266/open-new-session-in-another-tab branch April 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants