-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve opening another tab with new session with the same user #387
Merged
tikhanovichA
merged 8 commits into
develop
from
fix/INF-266/open-new-session-in-another-tab
Apr 23, 2024
Merged
fix: Improve opening another tab with new session with the same user #387
tikhanovichA
merged 8 commits into
develop
from
fix/INF-266/open-new-session-in-another-tab
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikhanovichA
requested review from
hectoras,
gabrielfs7,
bartlomiejmarszal and
pnal
April 12, 2024 07:19
gabrielfs7
reviewed
Apr 12, 2024
gabrielfs7
reviewed
Apr 12, 2024
hectoras
reviewed
Apr 15, 2024
hectoras
reviewed
Apr 15, 2024
gabrielfs7
reviewed
Apr 15, 2024
gabrielfs7
reviewed
Apr 15, 2024
…yExecutionsForUser
hectoras
approved these changes
Apr 16, 2024
gabrielfs7
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tikhanovichA
Only code check, I cannot test the feature locally, but it must be covered by QA
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 0 feature, 8 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/INF-266
Depends on oat-sa/extension-tao-testqti#2456
For cases when one of sessions was finished and then reopened the pausing for another tabs worked not like expected.
How to test:
Screen.Recording.2024-04-12.at.08.59.03.mov