Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUT-3586] feat: Adding new Usage tab on items layer #476

Closed
wants to merge 4 commits into from

Conversation

KirylHatalski
Copy link

@KirylHatalski KirylHatalski commented Apr 9, 2024

Ticket: AUT-3586

What's Changed

  • Added new tab with item usage statistic

Demo

image

How to test

  • Launch Items section
  • Open the Usage tab

Copy link

github-actions bot commented Apr 9, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
13 13 0 0

@jsconan jsconan self-requested a review April 10, 2024 06:51
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. The approach is correct. Obviously, the feature is not working yet, but the skeleton is correct.

@KirylHatalski KirylHatalski changed the title feat: [WIP] Adding new Usage tab on items layer [AUT-3586] feat: Adding new Usage tab on items layer Apr 10, 2024
@KirylHatalski KirylHatalski marked this pull request as ready for review April 10, 2024 12:32
Copy link

Version

Target Version 14.21.0
Last version 14.20.0

There are 0 BREAKING CHANGE, 4 features, 0 fix

* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright (c) 2018 (original work) Open Assessment Technologies SA (under the project TAO-PRODUCT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2018 (original work) Open Assessment Technologies SA (under the project TAO-PRODUCT);
* Copyright (c) 2024 (original work) Open Assessment Technologies SA (under the project TAO-PRODUCT);

Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think extension-tao-delivery-rdf is a proper extension to place this feature code

@KirylHatalski
Copy link
Author

Feature moved to another extension, new PR: https://github.com/oat-sa/extension-tao-deliver-connect/pull/190

@pnal pnal deleted the feat/AUT-3586/usage-statictic-ui branch April 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants