Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ADF-1734/Missing manifest registrations #166

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Jul 5, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1734

Summary

Add the missing registration for the PCI that prevent from using hot reload

Details

The hot reload relies on the manifest to select and copy the files to the registry

How to test

Copy link

github-actions bot commented Jul 5, 2024

Version

Target Version 3.8.13
Last version 3.8.12

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@jsconan jsconan requested a review from shaveko July 5, 2024 14:00
Copy link

github-actions bot commented Jul 5, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
0 0 0 0

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@jsconan jsconan merged commit b657abf into develop Jul 5, 2024
5 checks passed
@jsconan jsconan deleted the fix/ADF-1734/missing-manifest-declaration branch July 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants