-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype manifest v3 extension #2084
base: master
Are you sure you want to change the base?
Conversation
Deployed to Cloudflare Pages
|
Report too large to display inline |
package.json
Outdated
@@ -97,7 +97,7 @@ | |||
"typed-redux-saga": "1.5.0", | |||
"valid-url": "1.0.9", | |||
"webext-redux": "2.1.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webext-redux v4 supports manifest v3 and service workers, but looking at PR we will remove this dep completely. Did you encounter any issues when using it? Or did you find that brainstorming the problem without it was simply easier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make it simpler and more like our web wallet
webext-redux is needed to sync multiple extension popups and/or communication with dapps. We still don't have dapp communication, and we probably don't need multiple popups.
(we could also sync multiple popups the same way we sync web wallet tabs by enabling
wallet/src/app/state/persist/index.ts
Lines 19 to 20 in 8871626
/** Syncing tabs is only needed in web app, not in extension. */ | |
export const needsSyncingTabs = runtimeIs === 'webapp' |
…so fixes compile)
…icks wallet again
|
||
return ( | ||
<FromLedger | ||
webExtensionUSBLedgerAccess={() => { | ||
navigate('/open-wallet/ledger/usb') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh I thought our mechanism to request ledger permissions in ext worked completely differently. It requires redux syncing from openLedgerAccessPopup? :O
Closes #2073
Prototyped a few options with small increases in complexity:
3.+4.: Same behavior as manifest v2 - auto-unlock when popup opens