Delay GetEpoch request until needed #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/epoch
branch
2 times, most recently
from
a6bc87b
to
76f90de
Compare
lukaw3d
reviewed
Oct 22, 2024
Comment on lines
-60
to
-63
| const nic = yield* call(getOasisNic, network) | ||
| const { epoch } = yield* all({ | ||
| epoch: call([nic, nic.beaconGetEpoch], oasis.consensus.HEIGHT_LATEST), | ||
| }) |
There was a problem hiding this comment.
Hm, one thing I didn't consider before:
if grpc is down, users now won't know until they try to make a transaction
| const currentEpoch = useSelector(selectEpoch) | ||
| const remainingHours = (props.epoch - currentEpoch) / estimatedEpochsPerHour | ||
| if (!props.currentEpoch) { | ||
| return null |
There was a problem hiding this comment.
"Epoch: ${props.epoch}" would be a very good fallback
There was a problem hiding this comment.
will keep as is. default value would require handling isLoading for epoch in redux too. Without it, user would see "blinking" value / switching from default to target value.
Added commit to refetch epoch after network switch.
src/app/pages/OpenWalletPage/Features/FromMnemonic/__tests__/index.test.tsx
Show resolved
Hide resolved
src/app/pages/StakingPage/Features/DelegationList/DebondingDelegationList.tsx
Outdated
Show resolved
Hide resolved
lukaw3d
approved these changes
Oct 22, 2024
buberdds
force-pushed
the
mz/epoch
branch
2 times, most recently
from
8bbbf7e
to
6f1d3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of #1991
FromMnemonicnot related to changes. PR hits timeouts in CI because component callsgetAccountBalanceWithFallbacksaga for each account in modal. It is not needed in this unit tests.