Fix footer to work with existing translations #2026
Merged
+14
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
tjanez
approved these changes
Jul 30, 2024
lubej
approved these changes
Jul 31, 2024
src/app/components/Footer/index.tsx
Outdated
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| /> | ||
| {isMobileOrTablet ? <br /> : <span> </span>} |
There was a problem hiding this comment.
nit: Can we replace <span> </span> with either or {' '}. It is not obvious immediately what it is trying to do. And I think that it depends on the css white-space property, if it is going to be displayed correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2023
Example of existing translation that was broken:
"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"Reverts part of #1941 and #1961.