Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial load for pending txs on account page #1998

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jul 10, 2024

Description

Closes #1997
showPendingSection was "wrongly" evaluated, as it was changing on account loading state. Introduce new variable, that correctly takes into account initial loading state.

Links

https://www.loom.com/share/cda0241c8eaf4c21b20391aba69d3609

Copy link

github-actions bot commented Jul 10, 2024

Deployed to Cloudflare Pages

Latest commit: b0eff3abbdf51789bcdb6a65c15b705282be1284
Status:✅ Deploy successful!
Preview URL: https://f1afc509.oasis-wallet.pages.dev

@lubej lubej force-pushed the ml/fix-initial-load-for-pending-txs-on-account-page branch from 0144c03 to b0eff3a Compare July 10, 2024 08:26
@lubej lubej requested review from buberdds and lukaw3d July 10, 2024 08:29
@lubej lubej marked this pull request as ready for review July 10, 2024 10:50
@lubej lubej merged commit 5cde5dd into master Jul 10, 2024
13 checks passed
@lubej lubej deleted the ml/fix-initial-load-for-pending-txs-on-account-page branch July 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending transactions screen "flashes" during transaction loading
2 participants