Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show Delegations and Debonding tabs in account details #1946

Closed
wants to merge 2 commits into from
Closed

Only show Delegations and Debonding tabs in account details #1946

wants to merge 2 commits into from

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 21, 2024

Part of #276
localhost_3000_account_oasis1qpw6nzr77u5nfucee5wjp544hzgmpjjj2gz5p6zq_active-delegations(extension375x600 + scrollbar) localhost_3000_account_oasis1qpw6nzr77u5nfucee5wjp544hzgmpjjj2gz5p6zq_active-delegations(extension375x600 + scrollbar) (1) localhost_3000_account_oasis1qpw6nzr77u5nfucee5wjp544hzgmpjjj2gz5p6zq_active-delegations(extension375x600 + scrollbar) (2)

@lukaw3d lukaw3d requested review from buberdds and lubej May 21, 2024 15:13
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: f30c919c1b2189406b8088462a1014b6454e9b0a
Status:✅ Deploy successful!
Preview URL: https://7f8a95e0.oasis-wallet.pages.dev

lubej
lubej reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't tab selected on the second screenshot?

src/app/pages/AccountPage/index.tsx
route="debonding-delegations"
/>
</Nav>
<Box margin={{ bottom: 'small' }}></Box>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Box margin={{ bottom: 'small' }}></Box>
<Box margin={{ bottom: 'small' }} />

@lukaw3d
Copy link
Member Author

lukaw3d commented May 22, 2024

Why isn't tab selected on the second screenshot?

That's a tougher longstanding issue

ROSE Wallet tab:

  • /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km
  • /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km/active-delegations
  • /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km/debonding-delegations

Stake tab:

  • /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km/stake

So highlighting by prefix doesn't work (stake has the same prefix). We could modify the routes to have a common prefix /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km/account/*, but may need redirects for users with bookmarks. Or we could hardcode / || active-delegations || debonding-delegations. Or group them in react router and tag the group. Or highlight first tab if no other tab matches 🤷

@lubej
Copy link
Collaborator

lubej commented May 22, 2024

So highlighting by prefix doesn't work (stake has the same prefix). We could modify the routes to have a common prefix /account/oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km/account/*, but may need redirects for users with bookmarks. Or we could hardcode / || active-delegations || debonding-delegations. Or group them in react router and tag the group. Or highlight first tab if no other tab matches 🤷

I am all for hardcoding / || active-delegations || debonding-delegations. Not a fan of highlighting the first tab, if no other tab matches. The thing is, UX is kinda weird, if nothing is selected - at least to me. But would you select "ROSE Wallet" or "Stake"? Because "Stake" tab makes more sense to me.

@lukaw3d
Copy link
Member Author

lukaw3d commented May 22, 2024

Maybe Stake tab makes more sense. Then this pullrequest is completely wrong direction

@lukaw3d lukaw3d mentioned this pull request Jul 2, 2024
Merged
@lukaw3d lukaw3d closed this Jul 2, 2024
@lukaw3d
Copy link
Member Author

lukaw3d commented Jul 2, 2024

Replaced by #1985

@lukaw3d lukaw3d deleted the lw/acc-subnav branch July 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubej lubej lubej left review comments

@buberdds buberdds Awaiting requested review from buberdds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @lubej