-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android update screen #1945
Conversation
Deployed to Cloudflare Pages
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Note to self: Does update check run after user enters the wallet again. It should check only once, and then maybe once per day? |
db57985
to
69a7220
Compare
Current implementation checks for an update only on app launch. Which should be sufficient for current case, as the update can be skipped anyway. When mandatory update feature start to roll out, we should revisit the topic on what time interval the update check should be implemented. |
474422c
to
873ac82
Compare
fa89f31
to
bf6b091
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
- Coverage 80.24% 79.70% -0.54%
==========================================
Files 203 210 +7
Lines 5289 5411 +122
Branches 974 1001 +27
==========================================
+ Hits 4244 4313 +69
- Misses 1045 1098 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
af2c269
to
25d8858
Compare
- deny progressing in case unable to determine if update is available
Solution
Adds an update screen, when update is available on mobile platforms(currently only implemented for Android platform). Where clicking on "Update now" takes the user to the app store page.
Resources