Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split main workflow into build, lint and test workflows #1621

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

buberdds
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Deployed to Cloudflare Pages

Latest commit: a3209d4f6dc2e65742e16e7889de828e9e93565a
Status:✅ Deploy successful!
Preview URL: https://aaad46d6.oasis-wallet.pages.dev

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d1f721f
Status: ✅  Deploy successful!
Preview URL: https://5d60a537.oasis-wallet.pages.dev
Branch Preview URL: https://release.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.14s
✅ EDITORCONFIG editorconfig-checker 4 0 0.03s
⚠️ MARKDOWN markdownlint 1 0 1 1.17s
✅ MARKDOWN markdown-table-formatter 1 0 0 0.33s
✅ REPOSITORY checkov yes no 44.44s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 16.94s
✅ REPOSITORY trivy-sbom yes no 2.51s
✅ REPOSITORY trufflehog yes no 164.81s
✅ YAML prettier 3 0 0 0.77s
✅ YAML v8r 3 0 5.18s
✅ YAML yamllint 3 0 0.55s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@buberdds buberdds requested a review from tjanez August 31, 2023 09:17
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-lint.yml Show resolved Hide resolved
.github/workflows/ci-test.yml Show resolved Hide resolved
@buberdds buberdds changed the title Migrate release process Split main workflow into build, lint and test workflows Sep 6, 2023
@buberdds buberdds force-pushed the release branch 4 times, most recently from 5f8cf1a to 39d437d Compare September 6, 2023 10:37
1. first add it to Transifex and translate the strings,
2. create a folder with the new language code in `src/locales` and download the
translation file there,
translation file there,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated due to MegaLinter Wrong amount of left-padding spaces(want multiple of 2)

Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @buberdds!

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1621 (d1f721f) into master (0cefa17) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.04%     
==========================================
  Files         161      161              
  Lines        4147     4147              
  Branches      740      740              
==========================================
+ Hits         3435     3437       +2     
+ Misses        712      710       -2     
Flag Coverage Δ
cypress 51.15% <ø> (ø)
jest 77.91% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@buberdds buberdds merged commit 36fdbdd into master Sep 7, 2023
14 checks passed
@buberdds buberdds deleted the release branch September 7, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants