Merge pull request #1872 from oasisprotocol/lw/type-enter

Update text for delete account
oasisprotocol · Apr 6, 2024 · 4106814 · 4106814
2 parents c610ca8 + f34610a
commit 4106814
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/.changelog/1872.trivial.md b/.changelog/1872.trivial.md
@@ -0,0 +1 @@
+Update text for delete account
diff --git a/playwright/tests/toolbar.spec.ts b/playwright/tests/toolbar.spec.ts
@@ -126,7 +126,7 @@ test.describe('My Accounts tab', () => {
     await page.getByText('Delete Account').click()
     await page.getByTestId('account-delete-confirmation-input').fill('foo')
     await page.getByRole('button', { name: 'Yes, delete' }).click()
-    expect(page.getByText("Type 'delete'")).toBeVisible()
+    expect(page.getByText("Type 'delete'", { exact: true })).toBeVisible()
     await page.getByTestId('account-delete-confirmation-input').fill('delete')
     await page.getByRole('button', { name: 'Yes, delete' }).click()
     await expect(page).not.toHaveURL(new RegExp(`/account/${mnemonicAddress0}`))

diff --git a/src/app/components/Toolbar/Features/Account/DeleteAccount.tsx b/src/app/components/Toolbar/Features/Account/DeleteAccount.tsx
@@ -52,7 +52,7 @@ export const DeleteAccount = ({ onCancel, onDelete, wallet }: DeleteAccountProps
               <Paragraph fill textAlign="center">
                 {t(
                   'toolbar.settings.delete.inputHelp',
-                  `This action cannot be undone. To continue please enter '{{confirmationKeyword}}' below.`,
+                  `This action cannot be undone. To continue please type '{{confirmationKeyword}}' below.`,
                   {
                     confirmationKeyword: t('deleteForm.confirmationKeyword', 'delete'),
                   },

diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -467,7 +467,7 @@
       "contacts": "Contacts",
       "delete": {
         "description": "Are you sure you want to delete the following account?",
-        "inputHelp": "This action cannot be undone. To continue please enter '{{confirmationKeyword}}' below.",
+        "inputHelp": "This action cannot be undone. To continue please type '{{confirmationKeyword}}' below.",
         "title": "Delete Account",
         "tooltip": "You must have at least one account at all times."
       },