.github/workflows/docker.yml: Restrict permissions for GITHUB_TOKEN

[anzoman]

As a good security practice, we should grant the GITHUB_TOKEN the least required access.

[gw0]

You addressed #18 (comment). While at it, can you also address #18 (comment). I suggest you stop marking comments as resolved if there are still open things.

[anzoman]

Ok, I have addressed the other comment in another commit.

I suggest you stop marking comments as resolved if there are still open things.

Sorry, did not see you meant to rename all occurrences of this particular variable. I just renamed the final one and therefore resolved the comment.

Regarding the process, do you think it’s better for the reviewer to always resolve comments, or would you prefer I continue marking them resolved after changes?

[gw0]

Regarding the process, do you think it’s better for the reviewer to always resolve comments, or would you prefer I continue marking them resolved after changes?

It depends on whether they are trivial or if there are still open things (even if they are still discussed after the PR gets merged).