-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts: calldata encryption function (Solidity) #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
CedarMist
force-pushed
the
CedarMist/calldataencryption-v2
branch
from
October 31, 2024 10:23
4a32e74
to
c4f36d3
Compare
Running the test against localnet fails for me
|
That could happen if you don't build the clients/js package, the solidity tests require repeatability so I had to modify the client to pass a custom nonce. If the clients/js package isn't rebuilt, the solidity tests will use the last build you did which will generate a nonce every time and ignore the one passed in. |
rube-de
reviewed
Nov 4, 2024
CedarMist
force-pushed
the
CedarMist/calldataencryption-v2
branch
from
November 4, 2024 15:57
8311dc9
to
d4c083f
Compare
rube-de
approved these changes
Nov 4, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 4, 2024
…edarMist/calldataencryption-v2 contracts: calldata encryption function (Solidity) ef8c480
github-actions bot
added a commit
that referenced
this pull request
Nov 4, 2024
…darMist/calldataencryption-v2 contracts: calldata encryption function (Solidity) ef8c480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #436
Implements calldata encryption to create encrypted transactions from contracts on Sapphire.
This also updates Cipher TS to accept an optional
nonce
parameter, this means we can do easier deterministic tests to verify the Solidity implementation matches the Typescript implementation.