Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP1559 and EIP2930 signer libraries. #447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add EIP1559 and EIP2930 signer libraries. #447

wants to merge 2 commits into from

Conversation

ZigaMr
Copy link
Contributor

@ZigaMr ZigaMr commented Oct 29, 2024 •
edited
Loading

This PR adds libraries for signing Type1 (EIP-2930) and Type2 (EIP-1559) transactions as described in #321

TODO:

  • Add more tests for different combinations of MaxPriorityFeePerGas and MaxFeePerGas
  • Investigate gas usage when using access lists

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 2801ff5
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/6728fe1ea3b65600083c5872

@CedarMist CedarMist added the contracts Pull requests that update sapphire-contracts label Oct 31, 2024
@CedarMist CedarMist added this to the contracts-0.3.0 milestone Oct 31, 2024
@matevz matevz requested a review from rube-de November 5, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz Awaiting requested review from matevz

@CedarMist CedarMist Awaiting requested review from CedarMist

@rube-de rube-de Awaiting requested review from rube-de

At least 1 approving review is required to merge this pull request.

Assignees

@ZigaMr ZigaMr

Labels
contracts Pull requests that update sapphire-contracts
Projects
None yet
Milestone
contracts-0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ZigaMr @CedarMist