Bump golangci-lint to 1.63.4 #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintomazic
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
force-pushed
the
martin/trivial/fix/make-lint
branch
from
8738576 to
a89d279
Compare
peternose
reviewed
Jan 26, 2025
There was a problem hiding this comment.
The title is not clear. You are not fixing the make lint command, but the code to pass the lint check.
The comment is not clear. What is make-lint command? By noise you mean errors?
If you have problems with linter, you should downgrade yours to the one set in the code or even better, fix code and bump the linter (like in #5854).
martintomazic
force-pushed
the
martin/trivial/fix/make-lint
branch
from
a89d279 to
b8a041f
Compare
peternose
reviewed
Jan 26, 2025
martintomazic
force-pushed
the
martin/trivial/fix/make-lint
branch
from
b8a041f to
3973c3a
Compare
martintomazic
changed the title
martintomazic
force-pushed
the
martin/trivial/fix/make-lint
branch
from
3973c3a to
a70a646
Compare
peternose
approved these changes
Jan 26, 2025
martintomazic
force-pushed
the
martin/trivial/fix/make-lint
branch
from
a70a646 to
87c6072
Compare
peternose
approved these changes
Jan 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6011 +/- ##
===========================================
+ Coverage 0 65.12% +65.12%
===========================================
Files 0 631 +631
Lines 0 64419 +64419
===========================================
+ Hits 0 41956 +41956
- Misses 0 17549 +17549
- Partials 0 4914 +4914 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump golangci-lint to
1.63.4Warning
I only rename interface parameter names and some public methods' returned named values. This does not change the signature of functions so should not be breaking. Technically, if there would be tooling build around this, e.g. reflection, this would be breaking for the tooling. I don't think we have such clients, nor would this be breaking for the actual network etc...