Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Martin/feature/cached bundles clean up #5976

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Martin/feature/cached bundles clean up #5976

wants to merge 3 commits into from

Conversation

martintomazic
Copy link

WIP subject to force push

TODO:

What

#5737

Why

Save on disk usage/ease the maintenance.

How

  1. Exploded bundles no longer present in the config, are removed during node initialization (non-blocking by spawning separate go-routine).
  2. Bundles with version lower then active are also removed as part of another go-routine that watches runtime registry version updates and triggers a cleanup accordingly.

How to test

TODO instructions for manually testing

@martintomazic
go/runtime/registry: Clean stale exploded bundles
0753184 
Exploded bundles(either regular or detached), no longer
present in the config are automatically removed.

Removal is done in the background, to avoid blocking initialization.
@martintomazic
go/common/version: Expose Less function
a7d5fbd
@martintomazic
go/runtime/registry: Cleanup bundles for versions lower then active
8682e72
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 8682e72
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6760d09100ac520008700c70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko Awaiting requested review from kostko kostko will be requested when the pull request is marked ready for review kostko is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert will be requested when the pull request is marked ready for review peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh will be requested when the pull request is marked ready for review pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus will be requested when the pull request is marked ready for review ptrus is a code owner

@peternose peternose Awaiting requested review from peternose peternose will be requested when the pull request is marked ready for review peternose is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martintomazic