go: Bump go to 1.21.0 #5356
Merged
go: Bump go to 1.21.0 #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/feature/bump-go-1.21.0
branch
from
a9e32a0
to
958b615
Compare
peternose
force-pushed
the
peternose/feature/bump-go-1.21.0
branch
from
958b615
to
28a4d2b
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
reviewed
Aug 25, 2023
peternose
force-pushed
the
peternose/feature/bump-go-1.21.0
branch
from
28a4d2b
to
3ce917b
Compare
kostko
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the commits I decided to remove some unused parameters (e.g.
ctx,dataDir,identity). If needed, they can be added latter. However, I did not remove unused parameters inMaybeStartSubtreeandPutNode, as it is strange that the functions are not using them.TODOs (probably in another PR):
elliptic.Unmarshalfunction.tests/upgrade.tests/upgrade/postwith go 1.21.