go/oasis-node/cmd/config/migrate: Add runtime P2P seed address too #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abukosek
force-pushed
the
andrej/bugfix/migrate-seed-p2p-addrs
branch
from
ffa35e3
to
9304789
Compare
Codecov Report
@@ Coverage Diff @@
## master #5332 +/- ##
==========================================
- Coverage 67.64% 67.16% -0.49%
==========================================
Files 525 525
Lines 55806 55812 +6
==========================================
- Hits 37752 37488 -264
- Misses 13534 13773 +239
- Partials 4520 4551 +31
|
abukosek
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
peternose
approved these changes
Jul 26, 2023
kostko
reviewed
Jul 27, 2023
abukosek
force-pushed
the
andrej/bugfix/migrate-seed-p2p-addrs
branch
from
9304789
to
9fe270e
Compare
|
Fixed :) |
peternose
approved these changes
Jul 27, 2023
| @@ -134,6 +134,23 @@ func convertP2P(i interface{}, oldS string, newS string) []string { | |||
| return out | |||
| } | |||
|
|
|||
| // For each Tendermint seed node address, append the corresponding | |||
There was a problem hiding this comment.
For the future, I believe that comments in Golang should start with the function's name. The same holds for variables. Unfortunately, I cannot find any useful links to support my claim 😃
There was a problem hiding this comment.
OK, I'll fix this comment :)
abukosek
force-pushed
the
andrej/bugfix/migrate-seed-p2p-addrs
branch
from
9fe270e
to
ad143c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
config migratecommand, an additional P2P runtime seed address is added when migrating seed nodes.