-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/extra/conbench: Add consensus benchmark command #3183
base: master
Are you sure you want to change the base?
Conversation
fc5d9c3
to
524ed49
Compare
Codecov Report
@@ Coverage Diff @@
## master #3183 +/- ##
==========================================
- Coverage 66.02% 65.80% -0.23%
==========================================
Files 371 371
Lines 33285 33287 +2
==========================================
- Hits 21978 21906 -72
- Misses 8074 8134 +60
- Partials 3233 3247 +14
Continue to review full report at Codecov.
|
4ceebbc
to
387784c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good
a little reminiscent of https://github.com/oasisprotocol/oasis-core/blob/master/go/oasis-node/cmd/debug/txsource/workload/parallel.go the parallel workload. this is more robust to failures and adds measurements so we can get a transaction result out. a long time ago we were using a scheme where we'd take the middle 80% of the transactions to get the peak rate. oasis-core/clients/utils/src/benchmark.rs Line 105 in dce901f
|
7ca7793
to
32764f8
Compare
Thanks for taking a look at this. I can add the transaction cutting, but IMO it's not needed -- in my test runs, only the first block at the start of the benchmark had fewer transactions, the other blocks were always full. As long as there are enough samples (so that the duration of the benchmark is long enough), it won't significantly affect the results. |
9f8f23c
to
2fd24b3
Compare
780ea81
to
396a9d3
Compare
322c811
to
c21c1f6
Compare
1976c1d
to
2c80821
Compare
2c80821
to
b487942
Compare
No description provided.