Merge pull request #5342 from oasisprotocol/ptrus/fix/storage-sync-ba…

…ckoff2 storage/sync: don't immediately trigger more round fetches on failures
oasisprotocol · Aug 9, 2023 · 7e75db2 · 7e75db2
2 parents 6003203 + 77211dc
commit 7e75db2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.changelog/5326.bugfix.md b/.changelog/5326.bugfix.md
@@ -0,0 +1 @@
+storage/sync: don't immediately trigger more round fetches on failures
diff --git a/go/worker/storage/committee/node.go b/go/worker/storage/committee/node.go
@@ -1247,10 +1247,12 @@ mainLoop:
 				syncingRounds[item.round].retry(item.thisRoot.Type)
 			} else {
 				heap.Push(outOfOrderDoneDiffs, item)
+				// Item was successfully processed, trigger more round fetches.
+				// This ensures that new rounds are processed as fast as possible
+				// when we're syncing and are far behind.
+				triggerRoundFetches()
 			}
 
-			triggerRoundFetches()
-
 		case finalized := <-n.finalizeCh:
 			// If finalization failed, things start falling apart.
 			// There's no point redoing it, since it's probably not a transient