Merge pull request #5408 from oasisprotocol/ptrus/fix/empty-peer-id

fix consensus light client status shows empty peer IDs

.changelog/5408.bugfix.md

@@ -0,0 +1 @@
+Fix showing empty peer IDs in the Consensus light client status output

go/consensus/cometbft/light/p2p/p2p.go

@@ -189,6 +189,8 @@ func (lp *lightClientProvider) Initialized() <-chan struct{} {
 func (lp *lightClientProvider) PeerID() string {
 	peer := lp.getPeer()
 	if peer == nil {
+		// This happens if a provider is not yet initialized, or
+		// (less likely) if a peer was just dropped and no new peer is available.
 		return ""
 	}
 	return peer.String()

go/consensus/cometbft/light/service.go

@@ -106,7 +106,9 @@ func (c *client) GetStatus() (*consensus.LightClientStatus, error) {
 	}
 
 	for _, p := range c.providers {
-		status.PeerIDs = append(status.PeerIDs, p.PeerID())
+		if id := p.PeerID(); id != "" {
+			status.PeerIDs = append(status.PeerIDs, id)
+		}
 	}
 
 	return status, nil