Add ERC721 and ERC20 to hardcoded named accounts #798
Conversation
buberdds
changed the title
buberdds
changed the title
buberdds
force-pushed
the
mz/namedAcc
branch
from
927a622
to
24e37c6
Compare
| "Description": "ERC20" | ||
| }, | ||
| { | ||
| "Name": "YuzuSwap LP Token", |
There was a problem hiding this comment.
Why do we have multiple "YuzuSwap LP Token" 's/"Wrapped ROSE"... here? I thought we would just have "trusted"/"official" addresses, not the list of all verified tokens.
If we have a list of all verified contracts, can't we get that via the existing API? (
Line 1062 in 1f050d7
| "Description": "ERC20" | ||
| }, | ||
| { | ||
| "Name": "Sapphire Inu", |
There was a problem hiding this comment.
Same question here; I thought we would just have a couple of known/trusted addresses here, not all contracts.
Some of the token names are quite apparently non-serious/spam and don't belong in any "official list" like this one.
Also this seems really hard to maintain, whats the benefit vs using the evm_tokens API?
There was a problem hiding this comment.
agree, lists need more removals. Will try to find someone who can decide which tokens are "trusted" for us.
In Explorer we want to show token names instead of contract addresses in multiple places
named-accountsevm_tokensAPI endpoint