Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "storage: bump consensus RegistryEvents cache key" #792

Merged
merged 5 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/792.feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Revert "storage: bump consensus RegistryEvents cache key"
3 changes: 1 addition & 2 deletions storage/oasis/nodeapi/file/consensus.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ func (c *FileConsensusApiLite) GetEpoch(ctx context.Context, height int64) (beac
func (c *FileConsensusApiLite) RegistryEvents(ctx context.Context, height int64) ([]nodeapi.Event, error) {
return kvstore.GetSliceFromCacheOrCall(
c.db, height == consensus.HeightLatest,
// v2: Renamed some event fields.
kvstore.GenerateCacheKey("RegistryEvents.v2", height),
kvstore.GenerateCacheKey("RegistryEvents", height),
func() ([]nodeapi.Event, error) { return c.consensusApi.RegistryEvents(ctx, height) },
)
}
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e_regression/damask/rpc-cache/consensus/00000-1.psg
Git LFS file not shown
Binary file not shown.
Binary file modified tests/e2e_regression/damask/rpc-cache/consensus/db.pmt
Binary file not shown.
Binary file modified tests/e2e_regression/damask/rpc-cache/consensus/index.pmt
Binary file not shown.
4 changes: 2 additions & 2 deletions tests/e2e_regression/damask/rpc-cache/consensus/main.pix
Git LFS file not shown
Git LFS file not shown
4 changes: 2 additions & 2 deletions tests/e2e_regression/eden/rpc-cache/consensus/00000-1.psg
Git LFS file not shown
Binary file not shown.
Binary file modified tests/e2e_regression/eden/rpc-cache/consensus/db.pmt
Binary file not shown.
Binary file modified tests/e2e_regression/eden/rpc-cache/consensus/index.pmt
Binary file not shown.
4 changes: 2 additions & 2 deletions tests/e2e_regression/eden/rpc-cache/consensus/main.pix
Git LFS file not shown
4 changes: 2 additions & 2 deletions tests/e2e_regression/eden/rpc-cache/consensus/overflow.pix
Git LFS file not shown
Git LFS file not shown
Binary file not shown.
Binary file modified tests/e2e_regression/edenfast/rpc-cache/consensus/db.pmt
Binary file not shown.
Binary file modified tests/e2e_regression/edenfast/rpc-cache/consensus/index.pmt
Binary file not shown.
4 changes: 2 additions & 2 deletions tests/e2e_regression/edenfast/rpc-cache/consensus/main.pix
Git LFS file not shown
Git LFS file not shown
Loading