Merge pull request #517 from oasisprotocol/mitjat/upsert-votes

bugfix: analyzer/consensus: votes: upsert instead of insert
oasisprotocol · Sep 14, 2023 · dd13ca3 · dd13ca3
2 parents fb5d2fb + e2ee709
commit dd13ca3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/analyzer/consensus/consensus.go b/analyzer/consensus/consensus.go
@@ -783,7 +783,7 @@ func (m *processor) queueFinalizations(batch *storage.QueryBatch, data *storage.
 
 func (m *processor) queueVotes(batch *storage.QueryBatch, data *storage.GovernanceData) error {
 	for _, vote := range data.Votes {
-		batch.Queue(queries.ConsensusVoteInsert,
+		batch.Queue(queries.ConsensusVoteUpsert,
 			vote.ID,
 			vote.Submitter.String(),
 			vote.Vote,

diff --git a/analyzer/queries/queries.go b/analyzer/queries/queries.go
@@ -384,9 +384,11 @@ var (
     SET invalid_votes = $2
       WHERE id = $1`
 
-	ConsensusVoteInsert = `
+	ConsensusVoteUpsert = `
     INSERT INTO chain.votes (proposal, voter, vote)
-      VALUES ($1, $2, $3)`
+      VALUES ($1, $2, $3)
+    ON CONFLICT (proposal, voter) DO UPDATE SET
+	    vote = excluded.vote;`
 
 	RuntimeBlockInsert = `
     INSERT INTO chain.runtime_blocks (runtime, round, version, timestamp, block_hash, prev_block_hash, io_root, state_root, messages_hash, in_messages_hash, num_transactions, gas_used, size)