Merge pull request #739 from oasisprotocol/andrew7234/default-fee-symbol

Andrew7234/default fee symbol

.changelog/739.bugfix.md

@@ -0,0 +1,4 @@
+post 0.3.2 fixes
+
+api: filters out old rofl txs that were not parsed properly during a 2 week span in early july
+db: retroactively updates the runtime tx fee denom to default to ''.

CHANGELOG.md

@@ -121,7 +121,6 @@ The format is inspired by [Keep a Changelog].
 - Vendor oasis-core v24.0
   ([#716](https://github.com/oasisprotocol/nexus/issues/716))
 
-
 ## 0.3.1 (2024-05-27)
 
 ### Features

storage/client/queries/queries.go

@@ -485,7 +485,8 @@ const (
 			($3::text IS NULL OR txs.tx_hash = $3::text OR txs.tx_eth_hash = $3::text) AND
 			($4::text IS NULL OR rel.account_address = $4::text) AND
 			($5::timestamptz IS NULL OR txs.timestamp >= $5::timestamptz) AND
-			($6::timestamptz IS NULL OR txs.timestamp < $6::timestamptz)
+			($6::timestamptz IS NULL OR txs.timestamp < $6::timestamptz) AND
+			(signer0.signer_address IS NOT NULL) -- HACK: excludes malformed transactions that do not have the required fields
 		ORDER BY txs.round DESC, txs.tx_index DESC
 		LIMIT $7::bigint
 		OFFSET $8::bigint

storage/migrations/25_runtime_tx_denoms.up.sql

@@ -4,6 +4,6 @@ ALTER TABLE chain.runtime_transactions
     ADD COLUMN amount_symbol TEXT;
 
 ALTER TABLE chain.runtime_transactions
-    ADD COLUMN fee_symbol TEXT;
+    ADD COLUMN fee_symbol TEXT NOT NULL DEFAULT ''; -- Will be populated after reindex
 
 COMMIT;