-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NFT minting functionality to Quiz contract, quiz now displays s… #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
- hardhat task for setting an NFT and initializing a new NFT contract, if needed
- tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of merging the main branch https://github.com/oasisprotocol/demo-quiz/pull/3/files/93d55a1d09da32d5d81ce018a9a7dfd66976a78d..2a44bed3c185580d9847746aabe7ab64d3dfeb44 simply rebase your PR to the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits.
…, kept frontend changes Cosmetic changes Add SVG base64 image to NFT contract state, tests for OasisReward contract, update hardhat.config.ts and fix CI/CD workflows. Add automatically generated base64 image to NFT contract state, tests for NFT-OasisReward contract, update hardhat.config to include NFT deploy and setup Add separate tests for Rewards contract, increase gasless tx gasLimit parameter, add docBlock comments Add CI/CD update, cherry-pick whitelist commit from backup branch. Cosmetic changes Fix tests for CI/CD Update ci-test.yaml Add SVG base64 image to NFT contract state, tests for OasisReward contract, update hardhat.config.ts and fix CI/CD workflows. Add automatically generated base64 image to NFT contract state, tests for NFT-OasisReward contract, update hardhat.config to include NFT deploy and setup Add separate tests for Rewards contract, increase gasless tx gasLimit parameter, add docBlock comments Add CI/CD update, cherry-pick whitelist commit from backup branch. Cosmetic changes Fix tests for CI/CD Update ci-test.yaml Add Chain ID check to tests, add reward flags for NFT/ROSE Fix frontend/package.json Remove pnpm-lock.yaml Remove vscode settings, add natspec
…tatic NFT image after winning. Expect to add IPFS storage and auto-generated NFTs.
Implements #2