Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NFT minting functionality to Quiz contract, quiz now displays s… #3

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ZigaMr
Copy link
Collaborator

@ZigaMr ZigaMr commented Jul 16, 2024

…tatic NFT image after winning. Expect to add IPFS storage and auto-generated NFTs.

Implements #2

backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
@matevz matevz marked this pull request as ready for review July 17, 2024 12:28
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • hardhat task for setting an NFT and initializing a new NFT contract, if needed
  • tests

backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
backend/contracts/Quiz.sol Outdated Show resolved Hide resolved
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

.vscode/settings.json Outdated Show resolved Hide resolved
backend/contracts/OasisReward.sol Outdated Show resolved Hide resolved
…, kept frontend changes

Cosmetic changes

Add SVG base64 image to NFT contract state, tests for OasisReward contract, update hardhat.config.ts and fix CI/CD workflows.

Add automatically generated base64 image to NFT contract state, tests for NFT-OasisReward contract, update hardhat.config to include NFT deploy and setup

Add separate tests for Rewards contract, increase gasless tx gasLimit parameter, add docBlock comments

Add CI/CD update, cherry-pick whitelist commit from backup branch.

Cosmetic changes

Fix tests for CI/CD

Update ci-test.yaml

Add SVG base64 image to NFT contract state, tests for OasisReward contract, update hardhat.config.ts and fix CI/CD workflows.

Add automatically generated base64 image to NFT contract state, tests for NFT-OasisReward contract, update hardhat.config to include NFT deploy and setup

Add separate tests for Rewards contract, increase gasless tx gasLimit parameter, add docBlock comments

Add CI/CD update, cherry-pick whitelist commit from backup branch.

Cosmetic changes

Fix tests for CI/CD

Update ci-test.yaml

Add Chain ID check to tests, add reward flags for NFT/ROSE

Fix frontend/package.json

Remove pnpm-lock.yaml

Remove vscode settings, add natspec
@ZigaMr ZigaMr merged commit c0c4403 into oasisprotocol:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants