-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd/network): Autodetect chain context if none passed #317
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
61b21a5
to
da12da6
Compare
a420941
to
420f953
Compare
420f953
to
15d3ba6
Compare
15d3ba6
to
b205788
Compare
b205788
to
9b79844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, one minor nit.
"fmt" | ||
|
||
"github.com/spf13/cobra" | ||
|
||
"github.com/oasisprotocol/oasis-sdk/client-sdk/go/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please group these correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, thanks.
|
||
![code shell](../examples/network/06-list.in) | ||
|
||
![code shell](../examples/network/06-list.out) | ||
|
||
To automatically detect the chain context, simply run the command without the | ||
`[chain-context]` argument. This is especially useful for Localnet, where the | ||
chain context often changes each time you restart the `oasis-net-runner`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chain context often changes each time you restart the `oasis-net-runner`. | |
chain context changes each time you restart the `oasis-net-runner`: |
|
||
![code shell](../examples/network/06-list.in) | ||
|
||
![code shell](../examples/network/06-list.out) | ||
|
||
To automatically detect the chain context, simply run the command without the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To automatically detect the chain context, simply run the command without the | |
To automatically detect the chain context, simply omit the |
No description provided.