Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/network): Autodetect chain context if none passed #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amela
Copy link
Member

@amela amela commented Nov 13, 2024

No description provided.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for oasisprotocol-cli ready!

Name Link
🔨 Latest commit 9b79844
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6734dac5e0afdd00083b73dc
😎 Deploy Preview https://deploy-preview-317--oasisprotocol-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amela amela force-pushed the amela/detect-chain-context branch 3 times, most recently from 61b21a5 to da12da6 Compare November 13, 2024 10:04
@amela amela linked an issue Nov 13, 2024 that may be closed by this pull request
@amela amela force-pushed the amela/detect-chain-context branch 2 times, most recently from a420941 to 420f953 Compare November 13, 2024 10:16
@amela amela marked this pull request as ready for review November 13, 2024 10:22
@amela amela requested review from kostko and matevz November 13, 2024 10:22
cmd/network/set_chain_context.go Outdated Show resolved Hide resolved
cmd/network/set_chain_context.go Outdated Show resolved Hide resolved
@amela amela requested a review from matevz November 13, 2024 17:01
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, one minor nit.

"fmt"

"github.com/spf13/cobra"

"github.com/oasisprotocol/oasis-sdk/client-sdk/go/config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please group these correctly.

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks.


![code shell](../examples/network/06-list.in)

![code shell](../examples/network/06-list.out)

To automatically detect the chain context, simply run the command without the
`[chain-context]` argument. This is especially useful for Localnet, where the
chain context often changes each time you restart the `oasis-net-runner`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chain context often changes each time you restart the `oasis-net-runner`.
chain context changes each time you restart the `oasis-net-runner`:


![code shell](../examples/network/06-list.in)

![code shell](../examples/network/06-list.out)

To automatically detect the chain context, simply run the command without the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To automatically detect the chain context, simply run the command without the
To automatically detect the chain context, simply omit the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network set-chain-context: Autodetect chain context if none passed
3 participants