Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding shortcuts in Android 12.1+ #347

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

proletarius101
Copy link

@proletarius101 proletarius101 commented Apr 11, 2022

Fix #342

Tested on Android Emulator with API 32.

ghost
ghost previously approved these changes Apr 24, 2022
@proletarius101 proletarius101 marked this pull request as draft April 30, 2022 01:08
@proletarius101 proletarius101 marked this pull request as ready for review May 28, 2022 03:07
Copy link

@Hima88888888 Hima88888888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proletarius101
Copy link
Author

You may check https://cloudflare.f-droid.org/en/packages/com.oasisfeng.island.fdroid/ directly for the fixed usable version

@oasisfeng
Copy link
Owner

oasisfeng commented Aug 19, 2022

This pull request removed the following code in the implementation of Island app-launch shortcut:

if (IslandManager.isReady(context, profile))
    Shuttle(context, profile).launchNoThrows { requestPinAsUser(this, app, dynamic) }

This piece of code gives the shortcut different badge for different Island.

Is that the cause of the mentioned issue?

@proletarius101
Copy link
Author

proletarius101 commented Sep 30, 2022

Hi @oasisfeng , can you explain why do you need to add dynamic shortcuts? The instruction in https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts shows that only pinned shortcuts are useful in this case. Or is that useful when you enable the frozen icon indicator feature? If that's the case, it's a misunderstanding of dynamic shortcuts. Pinned icons labels can also be changed.
That helps my investigation

Copy link

@Av-Srt Av-Srt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@AtFreezingPoint AtFreezingPoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants