-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adding shortcuts in Android 12.1+ #347
base: dev
Are you sure you want to change the base?
Conversation
6d5c59b
to
e9c7ec1
Compare
ec82766
to
147181b
Compare
Ssince the APIs I use supports them according to the doc, I believe it works for all Island supported platform levels:
|
cab91b5
to
14d40bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may check https://cloudflare.f-droid.org/en/packages/com.oasisfeng.island.fdroid/ directly for the fixed usable version |
This pull request removed the following code in the implementation of Island app-launch shortcut:
This piece of code gives the shortcut different badge for different Island. Is that the cause of the mentioned issue? |
use Google Shortcuts Integration Library (https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts#gsi-library) to bypass the maximum shortcut limit
Hi @oasisfeng , can you explain why do you need to add dynamic shortcuts? The instruction in https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts shows that only pinned shortcuts are useful in this case. Or is that useful when you enable the frozen icon indicator feature? If that's the case, it's a misunderstanding of dynamic shortcuts. Pinned icons labels can also be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fix #342
Tested on Android Emulator with API 32.