Merge pull request #603 from chisholm/relational-data-sink-update-dic…

…t-unit-test Minor fix to certain relational data sink unit tests related to dictionary properties
oasis-open · Sep 17, 2024 · 3f17c0f · 3f17c0f
2 parents f294727 + c847a5c
commit 3f17c0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/stix2/properties.py b/stix2/properties.py
@@ -504,7 +504,7 @@ def clean(self, value, allow_custom=False, strict=False):
                     except CustomContentError:
                         # Need to propagate these, not treat as a type error
                         raise
-                    except Exception as e:
+                    except Exception:
                         # clean failed; value must not conform to type_
                         # Should be a narrower exception type here, but I don't
                         # know if it's safe to assume any particular exception

diff --git a/stix2/test/v21/test_datastore_relational_db.py b/stix2/test/v21/test_datastore_relational_db.py
@@ -768,9 +768,7 @@ class Embedded(stix2.v21._STIXBase21):
 
     elif request.param == "dict-of":
         prop_variation = stix2.properties.DictionaryProperty(
-            # DictionaryProperty.valid_types does not accept property
-            # instances (except ListProperty instances), only classes...
-            valid_types=type(base_property)
+            valid_types=base_property
         )
         # key name doesn't matter here
         prop_variation_value = {"key": prop_value}