bll/storage: don't check source domain space on lsm #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a LiveStorageMigration, the code checked if the disk/image would fit not only on the destination, but also on the source. This because theoretically the snapshot image can grow until the disksize. But this means that if we needed to live migrate a 1TB disk, we need at least 1TB of free space on the source domain also. This is quite useless, and causes problems to move disks from (for example) an already overloaded source domain. As this check is neither being done when creating a simple snapshot, just drop the check on the source domain for LSM. Signed-off-by: Jean-Louis Dupond <[email protected]>
dupondje
force-pushed
the
fix/lsm_source_space
branch
from
5605512
to
711b30d
Compare
|
@sermakov-orion , @saksham-oracle can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a LiveStorageMigration, the code checked if the disk/image would fit not only on the destination, but also on the source. This because theoretically the snapshot image can grow until the disksize.
But this means that we needed to live migrate a 1TB disk, also at least 1TB of free space on the source domain.
This is quite useless, and causes problemns to move disks from for example an already overloaded source domain.
As this check is neither being done when creating a simple snapshot, just drop the check on the source domain.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]