Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error struct for 409 conflict errors #240

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Aug 7, 2023

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Distinguishing conflict errors is useful for clients attempting to do retries when an operation is rejected because of the lock being already taken

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, other than that lgtm

sdk/ovirtsdk/error.go Outdated Show resolved Hide resolved
@ahadas ahadas requested a review from bkhizgiy August 8, 2023 08:24
Distinguishing conflict errors is useful for clients attempting to do
retries when an operation is rejected because of the lock being already
taken

Signed-off-by: Benny Zlotnik <[email protected]>
@ahadas ahadas merged commit 556489d into oVirt:master Aug 8, 2023
3 checks passed
@bennyz bennyz deleted the conflict-error branch August 8, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants