Upgrade to Weld 3 #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernand
force-pushed
the
upgrade_to_weld_3
branch
from
78fcaa1
to
d252b07
Compare
|
SRPM build issue should be fixed by #35 |
mwperina
force-pushed
the
upgrade_to_weld_3
branch
from
d252b07
to
6db007a
Compare
|
Is this change still necessary? Anything we can do to help move this forward? (I think this is required by oVirt/ovirt-engine-sdk-ruby#10 ) |
Currently the tool fails to start the CDI container with the following error message: ``` [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java (generate-code) on project metamodel-tests: An exception occured while executing the Java class. WELD-001524: Unable to load proxy class for bean Implicit Bean [javax.enterprise.inject.Instance] with qualifiers [@default] with class interface javax.enterprise.inject.Instance using classloader java.net.URLClassLoader@2570b316: Could not initialize class org.jboss.classfilewriter.ClassFile: Exception java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @5e407e1b [in thread "weld-worker-7"] -> [Help 1] ``` I believe the reason for that is that the version of Weld that we use doesn't work well with Java 11 or later. This patch updates to Weld 3 to address that issue. Signed-off-by: Juan Hernandez <[email protected]>
sandrobonazzola
force-pushed
the
upgrade_to_weld_3
branch
from
6db007a
to
d8343d7
Compare
sandrobonazzola
requested review from
a team
and removed request for
mnecas and
oliel
|
I guess this requires an addition to https://github.com/oVirt/ovirt-dependencies or packaging weld3 as rpm in CentOS Virt SIG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tool fails to start the CDI container with the following error message:
I believe the reason for that is that the version of Weld that we use doesn't work well with Java 11 or later. This patch updates to Weld 3 to address that issue.