This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Add a bunch of new APIs #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercharlesliu
commented
Nov 27, 2018
supercharlesliu
commented
- Add Team CRUD APIs & TeamMember APIs
- Add User API: Get & Update
- Add Datasource API: Datasources
- Add OrgPreferences API: Get & Update
- Add foler permission API: GET & Update
* Add DashboardsByFolder to search dashborads in a folder * Add DashboardByUid to support get dashboard by uid * Add GetDashboardIdByUid, GetDashboardUidById to support id <=> uid
|
Can you merge this request? |
|
Any update on when this will be merged? |
fspijkerman
reviewed
Aug 14, 2019
| } | ||
|
|
||
| func (c *Client) Team(id int64) (Team, error) { | ||
| team := Team{} |
There was a problem hiding this comment.
Should this not be?
func (c *Client) Team(id int64) (*Team, error) {
team := &Team{}
fspijkerman
reviewed
Aug 14, 2019
| return team, err | ||
| } | ||
|
|
||
| func (c *Client) UpdateTeam(id string, name string) error { |
fspijkerman
reviewed
Aug 14, 2019
| return err | ||
| } | ||
|
|
||
| func (c *Client) DeleteTeam(id string) error { |
tonglil
reviewed
Jun 2, 2020
There was a problem hiding this comment.
Sorry to have left this PR to rot for a while.
As you may understand, it is challenging to review a such a large changeset.
If you (or someone else) don't mind breaking this PR into individual API PRs, that would help accelerate our ability to review and accept the changes.
NOTE, there are already PRs for these APIs, so you can probably merge or omit breaking out the changes for them:
- Folder Permissions API Implementation of Folder Permissions API #36
- Team API Implementation of Team API #37
tonglil
added
waiting response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.