Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR removes some longstanding circular dependencies in the app without modifying app behavior. It also rearranges some tests to better reflect the new location of these dependencies.
I believe
server/list.js > server/docs.js > server/formatter.js
is causing the issues, but eventually we should work towards getting rid of all of them.Cycles to resolve:
Detected via
npx madge --circular .
Related Issue
Towards #361
Motivation and Context
With the release of v1.5.0, this bug could cause headaches for users after upgrading.
Checklist
npm run lint
and updated code style accordinglynpm run test
passes