-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use klauspost/compress/gzip instead of standard library #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives 40-50% improvements in CPU with very minor increase in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff. The library is mature and safe to be used in production. name old time/op new time/op delta GzipHandler_S2k-8 74.9µs ± 2% 34.4µs ± 2% -54.07% (p=0.000 n=10+9) GzipHandler_S20k-8 379µs ± 1% 226µs ± 3% -40.42% (p=0.000 n=9+10) GzipHandler_S100k-8 1.95ms ± 2% 1.15ms ± 1% -41.27% (p=0.000 n=9+9) GzipHandler_P2k-8 24.3µs ±25% 10.7µs ±25% -55.80% (p=0.000 n=10+10) GzipHandler_P20k-8 132µs ± 2% 75µs ± 1% -42.95% (p=0.000 n=9+10) GzipHandler_P100k-8 658µs ± 2% 371µs ± 3% -43.68% (p=0.000 n=9+10) name old alloc/op new alloc/op delta GzipHandler_S2k-8 7.71kB ± 5% 9.13kB ± 7% +18.33% (p=0.000 n=10+10) GzipHandler_S20k-8 65.1kB ± 3% 70.3kB ± 3% +8.05% (p=0.000 n=10+10) GzipHandler_S100k-8 348kB ± 4% 382kB ± 2% +9.85% (p=0.000 n=10+10) GzipHandler_P2k-8 7.60kB ± 1% 7.93kB ± 2% +4.33% (p=0.000 n=10+10) GzipHandler_P20k-8 64.4kB ± 1% 66.3kB ± 2% +2.92% (p=0.000 n=10+10) GzipHandler_P100k-8 304kB ± 1% 309kB ± 1% +1.67% (p=0.000 n=10+9) name old allocs/op new allocs/op delta GzipHandler_S2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_S20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_S100k-8 27.0 ± 0% 27.0 ± 0% ~ (all equal) GzipHandler_P2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_P20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_P100k-8 26.0 ± 0% 26.0 ± 0% ~ (all equal)
agnivade
added a commit
to mattermost/mattermost
that referenced
this pull request
Sep 9, 2020
It looks like maintainers aren't very active on the repo and nytimes/gziphandler#107 has come to a standstill. I don't want to wait forever for this to go in. Let's use a replace directive to point to the fork. When the PR gets merged, we can just bump the dependency and remove the replace directive. Re: the PR, copying the text from the PR description This gives 40-50% improvements in CPU with very minor increase in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff. The library is mature and safe to be used in production. ``` name old time/op new time/op delta GzipHandler_S2k-8 74.9µs ± 2% 34.4µs ± 2% -54.07% (p=0.000 n=10+9) GzipHandler_S20k-8 379µs ± 1% 226µs ± 3% -40.42% (p=0.000 n=9+10) GzipHandler_S100k-8 1.95ms ± 2% 1.15ms ± 1% -41.27% (p=0.000 n=9+9) GzipHandler_P2k-8 24.3µs ±25% 10.7µs ±25% -55.80% (p=0.000 n=10+10) GzipHandler_P20k-8 132µs ± 2% 75µs ± 1% -42.95% (p=0.000 n=9+10) GzipHandler_P100k-8 658µs ± 2% 371µs ± 3% -43.68% (p=0.000 n=9+10) name old alloc/op new alloc/op delta GzipHandler_S2k-8 7.71kB ± 5% 9.13kB ± 7% +18.33% (p=0.000 n=10+10) GzipHandler_S20k-8 65.1kB ± 3% 70.3kB ± 3% +8.05% (p=0.000 n=10+10) GzipHandler_S100k-8 348kB ± 4% 382kB ± 2% +9.85% (p=0.000 n=10+10) GzipHandler_P2k-8 7.60kB ± 1% 7.93kB ± 2% +4.33% (p=0.000 n=10+10) GzipHandler_P20k-8 64.4kB ± 1% 66.3kB ± 2% +2.92% (p=0.000 n=10+10) GzipHandler_P100k-8 304kB ± 1% 309kB ± 1% +1.67% (p=0.000 n=10+9) name old allocs/op new allocs/op delta GzipHandler_S2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_S20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_S100k-8 27.0 ± 0% 27.0 ± 0% ~ (all equal) GzipHandler_P2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_P20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_P100k-8 26.0 ± 0% 26.0 ± 0% ~ (all equal) ``` https://mattermost.atlassian.net/browse/MM-28491
agnivade
added a commit
to mattermost/mattermost
that referenced
this pull request
Sep 10, 2020
It looks like maintainers aren't very active on the repo and nytimes/gziphandler#107 has come to a standstill. I don't want to wait forever for this to go in. Let's use a replace directive to point to the fork. When the PR gets merged, we can just bump the dependency and remove the replace directive. Re: the PR, copying the text from the PR description This gives 40-50% improvements in CPU with very minor increase in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff. The library is mature and safe to be used in production. ``` name old time/op new time/op delta GzipHandler_S2k-8 74.9µs ± 2% 34.4µs ± 2% -54.07% (p=0.000 n=10+9) GzipHandler_S20k-8 379µs ± 1% 226µs ± 3% -40.42% (p=0.000 n=9+10) GzipHandler_S100k-8 1.95ms ± 2% 1.15ms ± 1% -41.27% (p=0.000 n=9+9) GzipHandler_P2k-8 24.3µs ±25% 10.7µs ±25% -55.80% (p=0.000 n=10+10) GzipHandler_P20k-8 132µs ± 2% 75µs ± 1% -42.95% (p=0.000 n=9+10) GzipHandler_P100k-8 658µs ± 2% 371µs ± 3% -43.68% (p=0.000 n=9+10) name old alloc/op new alloc/op delta GzipHandler_S2k-8 7.71kB ± 5% 9.13kB ± 7% +18.33% (p=0.000 n=10+10) GzipHandler_S20k-8 65.1kB ± 3% 70.3kB ± 3% +8.05% (p=0.000 n=10+10) GzipHandler_S100k-8 348kB ± 4% 382kB ± 2% +9.85% (p=0.000 n=10+10) GzipHandler_P2k-8 7.60kB ± 1% 7.93kB ± 2% +4.33% (p=0.000 n=10+10) GzipHandler_P20k-8 64.4kB ± 1% 66.3kB ± 2% +2.92% (p=0.000 n=10+10) GzipHandler_P100k-8 304kB ± 1% 309kB ± 1% +1.67% (p=0.000 n=10+9) name old allocs/op new allocs/op delta GzipHandler_S2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_S20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_S100k-8 27.0 ± 0% 27.0 ± 0% ~ (all equal) GzipHandler_P2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_P20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_P100k-8 26.0 ± 0% 26.0 ± 0% ~ (all equal) ``` https://mattermost.atlassian.net/browse/MM-28491
mickmister
pushed a commit
to mattermost/mattermost
that referenced
this pull request
Sep 18, 2020
MM-27199 - Add metrics to MM server for total enabled user count (#15116) * Add metrics to MM server for total enabled user count and include installation ID from a new env var * diagnostics context Co-authored-by: Mattermod <[email protected]> [Weblate] Fix empty/unchanged translations. Add Bulgarian language. Add general translation updates. (#15375) * Translated using Weblate (German) Currently translated at 94.1% (1887 of 2005 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ Translated using Weblate (German) Currently translated at 96.5% (1934 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ * Translated using Weblate (Japanese) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ * Translated using Weblate (Italian) Currently translated at 99.5% (1995 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ Translated using Weblate (Italian) Currently translated at 99.1% (1986 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ Translated using Weblate (French) Currently translated at 96.2% (1929 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ * Translated using Weblate (Romanian) Currently translated at 99.4% (1990 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 99.5% (1993 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Polish) Currently translated at 95.9% (1920 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Korean) Currently translated at 98.7% (1977 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ko/ Translated using Weblate (Japanese) Currently translated at 99.5% (1993 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ Translated using Weblate (Italian) Currently translated at 99.1% (1984 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ Translated using Weblate (French) Currently translated at 95.8% (1918 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ Translated using Weblate (Spanish) Currently translated at 99.5% (1993 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Translated using Weblate (German) Currently translated at 96.0% (1923 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ Translated using Weblate (Chinese (Traditional)) Currently translated at 99.1% (1991 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Chinese (Simplified)) Currently translated at 97.9% (1968 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Translated using Weblate (Ukrainian) Currently translated at 95.7% (1924 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Translated using Weblate (Turkish) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Russian) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ Translated using Weblate (Romanian) Currently translated at 99.4% (1997 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Polish) Currently translated at 95.9% (1927 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Dutch) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Korean) Currently translated at 98.7% (1984 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ko/ Translated using Weblate (Japanese) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ Translated using Weblate (Italian) Currently translated at 99.1% (1991 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ Translated using Weblate (French) Currently translated at 95.8% (1925 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ Translated using Weblate (Spanish) Currently translated at 99.5% (2000 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Translated using Weblate (German) Currently translated at 96.0% (1930 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ * Translated using Weblate (Russian) Currently translated at 100.0% (2009 of 2009 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ * Translated using Weblate (Turkish) Currently translated at 100.0% (2007 of 2007 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Turkish) Currently translated at 99.9% (2005 of 2007 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Turkish) Currently translated at 99.8% (2004 of 2007 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ * Translated using Weblate (Dutch) Currently translated at 100.0% (2001 of 2001 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Dutch) Currently translated at 100.0% (2002 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ * Translated using Weblate (Spanish) Currently translated at 99.3% (1993 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Translated using Weblate (Japanese) Currently translated at 99.3% (1993 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ Translated using Weblate (French) Currently translated at 95.6% (1918 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ Translated using Weblate (German) Currently translated at 94.1% (1888 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ Translated using Weblate (Chinese (Simplified)) Currently translated at 97.7% (1961 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Translated using Weblate (Chinese (Traditional)) Currently translated at 98.9% (1983 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Chinese (Simplified)) Currently translated at 97.8% (1960 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Translated using Weblate (Ukrainian) Currently translated at 95.6% (1916 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Translated using Weblate (Turkish) Currently translated at 99.8% (2001 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Russian) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ Translated using Weblate (Romanian) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 99.4% (1992 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Polish) Currently translated at 95.7% (1919 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Korean) Currently translated at 98.6% (1976 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ko/ Translated using Weblate (Japanese) Currently translated at 99.4% (1992 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ Translated using Weblate (French) Currently translated at 95.6% (1917 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ Translated using Weblate (Spanish) Currently translated at 99.4% (1992 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Translated using Weblate (German) Currently translated at 95.9% (1922 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ Translated using Weblate (Chinese (Traditional)) Currently translated at 99.1% (1984 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Chinese (Simplified)) Currently translated at 97.9% (1961 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Translated using Weblate (Ukrainian) Currently translated at 95.7% (1917 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Translated using Weblate (Russian) Currently translated at 100.0% (2002 of 2002 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ * Translated using Weblate (Italian) Currently translated at 98.8% (1981 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ * Translated using Weblate (Romanian) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ * Translated using Weblate (Russian) Currently translated at 100.0% (2004 of 2004 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ * Translated using Weblate (Ukrainian) Currently translated at 94.4% (1908 of 2020 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Added translation using Weblate (Bulgarian) Translated using Weblate (Portuguese (Brazil)) Currently translated at 98.7% (1980 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Polish) Currently translated at 91.9% (1844 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Chinese (Traditional)) Currently translated at 98.6% (1978 of 2005 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Ukrainian) Currently translated at 84.1% (1687 of 2005 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ * Translated using Weblate (Romanian) Currently translated at 99.9% (2005 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Chinese (Traditional)) Currently translated at 98.6% (1979 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Korean) Currently translated at 98.5% (1977 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ko/ Translated using Weblate (Polish) Currently translated at 92.5% (1856 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Turkish) Currently translated at 99.8% (2002 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Ukrainian) Currently translated at 84.1% (1689 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 99.3% (1992 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Dutch) Currently translated at 99.8% (2002 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Russian) Currently translated at 99.9% (2005 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ Translated using Weblate (Italian) Currently translated at 98.8% (1982 of 2006 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ * Translated using Weblate (Chinese (Traditional)) Currently translated at 97.9% (1978 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hant/ Translated using Weblate (Chinese (Simplified)) Currently translated at 96.8% (1955 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Translated using Weblate (Ukrainian) Currently translated at 94.5% (1908 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/uk/ Translated using Weblate (Turkish) Currently translated at 98.8% (1996 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Russian) Currently translated at 99.5% (2009 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ Translated using Weblate (Romanian) Currently translated at 99.0% (1999 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 98.4% (1987 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/ Translated using Weblate (Polish) Currently translated at 94.7% (1913 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/ Translated using Weblate (Dutch) Currently translated at 98.8% (1996 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Korean) Currently translated at 97.6% (1971 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ko/ Translated using Weblate (Japanese) Currently translated at 98.4% (1987 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ Translated using Weblate (Italian) Currently translated at 97.8% (1976 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/it/ Translated using Weblate (French) Currently translated at 94.6% (1911 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/fr/ Translated using Weblate (Spanish) Currently translated at 99.8% (2016 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Translated using Weblate (German) Currently translated at 94.8% (1916 of 2019 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ Translated using Weblate (Russian) Currently translated at 99.9% (2005 of 2007 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ru/ * Translated using Weblate (Bulgarian) Currently translated at 0.0% (0 of 2023 strings) Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/bg/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ * Clean empty string. * Remove failing source string in Bulgarian language. Co-authored-by: Elisabeth Kulzer <[email protected]> Co-authored-by: kaakaa <[email protected]> Co-authored-by: Zack-83 <[email protected]> Co-authored-by: rodrigocorsi <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Mattermost Weblate Notify Bot <[email protected]> Co-authored-by: Alexey Napalkov <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Viorel-Cosmin Miron <[email protected]> Co-authored-by: Anonymous <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> [MM-27967] api4/config_test: fix flaky test if siteurl is already set (#15403) * api4/config_test: fix flaky test if siteurl is already set * api4/apitelib enforce siteurl not set Clean caches on depcheck failure (#15407) MM-27953: Fix flaky test TestTeamStore//SearchPrivate (#15409) We got hit by yet another random text search issue, but this was on the more extreme end because this was a string of length 4 and still it collided. I am not sure if there is a fool proof solution to this than just going for a larger string. https://mattermost.atlassian.net/browse/MM-27953 MM-28226: Admin Advisor: add mitigations (#15379) * Admin Advisor: add mitigation Moving diagnostics into a service (#14832) * Moving diagnostics into a service * Fixing golint checks * Fixing tests * Renaming from diagnostics to telemetry * Adding missing files * Initializing telemetry earlier in the server startup * Fixing tests * Adding a log for the telemetryID initialization error * Addressing PR review comments * Fixing merge problem * Removing some extra Diagnostics mentions * Making tests pass [MM-27952] Fix some logging related races (#15404) * Fix some logging races * Move initLogging after config store initialization Fix panic in api4.searchPosts (#15410) MM-28444: Optimize GetPostsSince in postgres (#15411) GetPostsSince is used when loading posts for a channel. An opportunity for optimization is that the primary SQL query is repeated twice and then a UNION is constructed for the results. ``` SELECT * FROM Posts WHERE UpdateAt > :Time AND ChannelId = :ChannelId LIMIT 1000 ``` But we can use a CTE for this which caches the results to be reused later. This leads to the main query being executed once rather than twice. And from Postgres 12 onwards, CTEs can be inlined which opens the door to further optimizations. From the docs (https://www.postgresql.org/docs/10/queries-with.html) > A useful property of WITH queries is that they are evaluated only once per execution of the parent query, even if they are referred to more than once by the parent query or sibling WITH queries. Thus, expensive calculations that are needed in multiple places can be placed within a WITH query to avoid redundant work. Another possible application is to prevent unwanted multiple evaluations of functions with side-effects. However, the other side of this coin is that the optimizer is less able to push restrictions from the parent query down into a WITH query than an ordinary subquery. In our case, the caveat does not apply because we are only filtering columns and not rows, so we can safely use it. Following are the query plan comparisons: Old: http://tatiyants.com/pev/#/plans/plan_1599394993105 New: http://tatiyants.com/pev/#/plans/plan_1599395970886 As we can see, in old bitmap index scan+heap scan happens twice, but in the new one, it happens only once. This has been load tested with a large dataset and confirmed to exhibit good improvements. MM-27744 disable Zap for unit tests. (#15398) MM-27744 disable Zap for unit tests. Zap has no concept of shutdown or close. Zap is only shutdown when the app exits. Not a problem for console logging, but when creating a new Zap logger that outputs to files on every unit test, that leaves no easy way to clean up until process exit. Depending on what else is running this can exhaust all file handles and cause unit tests to fail. Zap is now disabled unit tests and uses Logr instead, regardless of config settings. `make test-server` peak file handle usage dropped from ~5K to less than 100. Optimize gzip compression of responses (#15416) It looks like maintainers aren't very active on the repo and nytimes/gziphandler#107 has come to a standstill. I don't want to wait forever for this to go in. Let's use a replace directive to point to the fork. When the PR gets merged, we can just bump the dependency and remove the replace directive. Re: the PR, copying the text from the PR description This gives 40-50% improvements in CPU with very minor increase in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff. The library is mature and safe to be used in production. ``` name old time/op new time/op delta GzipHandler_S2k-8 74.9µs ± 2% 34.4µs ± 2% -54.07% (p=0.000 n=10+9) GzipHandler_S20k-8 379µs ± 1% 226µs ± 3% -40.42% (p=0.000 n=9+10) GzipHandler_S100k-8 1.95ms ± 2% 1.15ms ± 1% -41.27% (p=0.000 n=9+9) GzipHandler_P2k-8 24.3µs ±25% 10.7µs ±25% -55.80% (p=0.000 n=10+10) GzipHandler_P20k-8 132µs ± 2% 75µs ± 1% -42.95% (p=0.000 n=9+10) GzipHandler_P100k-8 658µs ± 2% 371µs ± 3% -43.68% (p=0.000 n=9+10) name old alloc/op new alloc/op delta GzipHandler_S2k-8 7.71kB ± 5% 9.13kB ± 7% +18.33% (p=0.000 n=10+10) GzipHandler_S20k-8 65.1kB ± 3% 70.3kB ± 3% +8.05% (p=0.000 n=10+10) GzipHandler_S100k-8 348kB ± 4% 382kB ± 2% +9.85% (p=0.000 n=10+10) GzipHandler_P2k-8 7.60kB ± 1% 7.93kB ± 2% +4.33% (p=0.000 n=10+10) GzipHandler_P20k-8 64.4kB ± 1% 66.3kB ± 2% +2.92% (p=0.000 n=10+10) GzipHandler_P100k-8 304kB ± 1% 309kB ± 1% +1.67% (p=0.000 n=10+9) name old allocs/op new allocs/op delta GzipHandler_S2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_S20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_S100k-8 27.0 ± 0% 27.0 ± 0% ~ (all equal) GzipHandler_P2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_P20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_P100k-8 26.0 ± 0% 26.0 ± 0% ~ (all equal) ``` https://mattermost.atlassian.net/browse/MM-28491 [MM-28397] Fix data race in SqlSupplier (#15419) * Fix data race in SqlSupplier * Add comment Co-authored-by: Mattermod <[email protected]> [MM-23003] Document sql store 'SqlTeamStore' methods (Task 8) fixes (#15318) Automatic Merge Add support for rc versions in upgrader (#15424) MM-28103: prepackage incident-response (#15360) Co-authored-by: Mattermod <[email protected]> MM-27957: Fix flaky test TestRecycleDBConns (#15415) https://mattermost.atlassian.net/browse/MM-27957 [MM-23651] No more than 256 members are allowed to be invited (#15414) * Update constant to 256 * update test Co-authored-by: Mattermod <[email protected]> app/post: continue to loop in case of an error (#15418) Implement LDAP Certificate (#15361) * Implement LDAP Certificate * add diagnostics and translations * update from code review * pass pointer to update pict function * pass object to first function * remove debug log messages * update test to add localmode test * update lint errors Co-authored-by: Mattermod <[email protected]> MM-28115: Add env var for telemetry installation type. (#15431) Fix telemetry initialization problem on placeholder usage (#15434) store/channel_store_categories: fix index out of bounds error (#15423) [MM-28033] Perform localcachelayer tests for one DB type only when in CI (#15433) * Perform localcachelayer tests for one DB type only if in CI * Add newStoreType() for sqlstore case ChannelStore migration Part 2 (#15405) * Migration completed * Several corrections in tests * Fix imports * Fix some errors after testing * Trigger CI * Fix tests * Suggestions * Suggestions * Add license Co-authored-by: Mattermod <[email protected]> [MM-28475] Add server telemetry for the new system roles (#15437) * MM-28475 Add server telemetry for the new system roles * Move system roles to permissions_system_scheme table * Add testing mocks [MM-26812] Add support for resumable file uploads (#15252) * Implement AppendFile for FileBackend * Split test into subtests * [MM-26812] Add support for resumable file uploads (#15252) * Implement UploadSession * Implement UploadSessionStore * Add error strings * Implement resumable file uploads * Add UploadType * Fix retry layer tests * Regenerate store layers * Fix store error handling * Use base for filename * Prevent concurrent uploads on the same upload session * Fix erroneus error string * Improve error handling Co-authored-by: Mattermod <[email protected]> * Fix translations Co-authored-by: Mattermod <[email protected]> [MM-28210] sqlstore/user_store: filter deleted users for GetProfilesInChannel (#15390) * sqlstore/user_store: filter deleted users for GetProfilesInChannel * allow GetProfilesInChannel use userGetOptions * sqlstore/user_store: add more test cases * store/user_store: refine filter Revert bulgarian language. (#15512) TeamStore migration Part 3 (#15397) * Migration completed * TODO MM-27169: Remove uneeded fields from App (#15408) * MM-27169: Remove uneeded fields from App https://mattermost.atlassian.net/browse/MM-27169 * run app-layers * Bring back searchengine Co-authored-by: Mattermod <[email protected]> TeamStore migration part 2 (#15396) * Migration completed * Fix tests * Reduce to one line * Fix: change to plain error * Fix imports * Trigger CI * Fix i18 * Fix merge with master * Trigger CI Fix failing test (#15522) Co-authored-by: Mattermod <[email protected]> [MM-25656] Adds a function to allow to update assets subpath in a given directory (#15020) [MM-28131] Fix desanitization of DataSourceReplicas and DataSourceSearchReplicas (#15389) * Fix desanitization of DataSourceReplicas and DataSourceSearchReplicas * Fix test case Co-authored-by: Mattermod <[email protected]>
There are already multiple replacements of the gzip implementation proposed. What we need is #106 so that anyone can choose the gzip implementation he/she likes. |
That would work too. |
genarocoronel
pushed a commit
to genarocoronel/GoLang-mattermostserver
that referenced
this pull request
Jun 9, 2021
It looks like maintainers aren't very active on the repo and nytimes/gziphandler#107 has come to a standstill. I don't want to wait forever for this to go in. Let's use a replace directive to point to the fork. When the PR gets merged, we can just bump the dependency and remove the replace directive. Re: the PR, copying the text from the PR description This gives 40-50% improvements in CPU with very minor increase in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff. The library is mature and safe to be used in production. ``` name old time/op new time/op delta GzipHandler_S2k-8 74.9µs ± 2% 34.4µs ± 2% -54.07% (p=0.000 n=10+9) GzipHandler_S20k-8 379µs ± 1% 226µs ± 3% -40.42% (p=0.000 n=9+10) GzipHandler_S100k-8 1.95ms ± 2% 1.15ms ± 1% -41.27% (p=0.000 n=9+9) GzipHandler_P2k-8 24.3µs ±25% 10.7µs ±25% -55.80% (p=0.000 n=10+10) GzipHandler_P20k-8 132µs ± 2% 75µs ± 1% -42.95% (p=0.000 n=9+10) GzipHandler_P100k-8 658µs ± 2% 371µs ± 3% -43.68% (p=0.000 n=9+10) name old alloc/op new alloc/op delta GzipHandler_S2k-8 7.71kB ± 5% 9.13kB ± 7% +18.33% (p=0.000 n=10+10) GzipHandler_S20k-8 65.1kB ± 3% 70.3kB ± 3% +8.05% (p=0.000 n=10+10) GzipHandler_S100k-8 348kB ± 4% 382kB ± 2% +9.85% (p=0.000 n=10+10) GzipHandler_P2k-8 7.60kB ± 1% 7.93kB ± 2% +4.33% (p=0.000 n=10+10) GzipHandler_P20k-8 64.4kB ± 1% 66.3kB ± 2% +2.92% (p=0.000 n=10+10) GzipHandler_P100k-8 304kB ± 1% 309kB ± 1% +1.67% (p=0.000 n=10+9) name old allocs/op new allocs/op delta GzipHandler_S2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_S20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_S100k-8 27.0 ± 0% 27.0 ± 0% ~ (all equal) GzipHandler_P2k-8 21.0 ± 0% 21.0 ± 0% ~ (all equal) GzipHandler_P20k-8 24.0 ± 0% 24.0 ± 0% ~ (all equal) GzipHandler_P100k-8 26.0 ± 0% 26.0 ± 0% ~ (all equal) ``` https://mattermost.atlassian.net/browse/MM-28491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives 40-50% improvements in CPU with very minor increase
in memory, just as a drop-in replacement. I think that is a very reasonable tradeoff.
The library is mature and safe to be used in production.
I do see a PR open for swappable gzip implementations, but that is open for several months. I don't mind if that goes in as long as I can replace the standard library implementation.
It is my hope that this will be upstreamed. Otherwise we would just have to fork this ourselves. Gzipping is a very intensive operation in our workload and this is a great cheap way to get some gains.