add new kubectl_version param
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
montmanu
commented
Jul 19, 2019
tonglil
reviewed
Jul 19, 2019
montmanu
force-pushed
the
kubectl-version-param
branch
2 times, most recently
from
e006ce7
to
439c307
Compare
tonglil
approved these changes
Jul 25, 2019
fsouza
approved these changes
Jul 26, 2019
montmanu
force-pushed
the
kubectl-version-param
branch
2 times, most recently
from
e913697
to
b06cd32
Compare
- enables running the plugin using a non-default `kubectl` executable - updates image `ENTRYPOINT` to support setting of `EXTRA_KUBECTL_VERSIONS` environment variable used by plugin to validate against `kubectl_version` depends on #114
montmanu
force-pushed
the
kubectl-version-param
branch
from
b06cd32
to
df1b5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables running the plugin using a non-default
kubectlexecutable from "extra" kubectl versions distributed with thegcloud kubectlcomponents.Updates
drone-gkeDocker imageENTRYPOINTto support setting ofEXTRA_KUBECTL_VERSIONSenvironment variable used by plugin to validate againstkubectl_version.Motivation
The primary motivation here was to provide a path forward for experimenting with
kustomize(see example repo that contains a POC for migrating vi tokustomize) which was released as part ofkubectlin v1.14)Related
#114