-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor build tooling #114
Merged
Merged
Commits on Jul 22, 2019
-
- adds required `GCLOUD_SDK_VERSION` `--build-arg` to `Dockerfile` - removes `Dockerfile.1.10`, `Dockerfile.1.11` (can now be customized via `GCLOUD_SDK_VERSION` build arg) - removes `bin/dist`; replaced with `make`-based implementation - adds several misc config / rc files - updates `README`, `DOCS.md` to reflect changes, address linting refactor build tooling - adds required `GCLOUD_SDK_VERSION` `--build-arg` to `Dockerfile` - removes `Dockerfile.1.10`, `Dockerfile.1.11` (can now be customized via `GCLOUD_SDK_VERSION` build arg) - removes `bin/dist`; replaced with `make`-based implementation - adds several misc config / rc files - updates `README`, `DOCS.md` to reflect changes, address linting Apply suggestions from code review Co-Authored-By: Chris Montoro <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 071a8e3 - Browse repository at this point
Copy the full SHA 071a8e3View commit details -
address PR feedback + misc changes
- remove cloud-sdk stage from Dockerfile - remove bin/install-kubectl ; add installation steps inline within Dockerfile - replaced references to CLOUD_SDK_VERSION / GCLOUD_SDK_VERSION with GCLOUD_SDK_TAG - move developer focused documentation to CONTRIBUTING.md - move .PHONY blocks to the line above each related target definition - add coverage.out make target - add check for go v 1.12+ - rename docker-release, docker-run-local make targets - add terraform integration to automate test resource provisioning - update DOCS.md to support deep links to individual parameters within API reference - update local-example app, image, API_TOKEN variable names to avoid potential confusion with drone-gke parameters
Configuration menu - View commit details
-
Copy full SHA for bc8b0a1 - Browse repository at this point
Copy the full SHA bc8b0a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a9980 - Browse repository at this point
Copy the full SHA b3a9980View commit details -
Configuration menu - View commit details
-
Copy full SHA for 515d7c6 - Browse repository at this point
Copy the full SHA 515d7c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 483e946 - Browse repository at this point
Copy the full SHA 483e946View commit details
Commits on Jul 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for af81393 - Browse repository at this point
Copy the full SHA af81393View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc3fb9 - Browse repository at this point
Copy the full SHA 5fc3fb9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.