Move content under statusBar if prefersStatusBarHidden is false

[sergiog90]

Allow developers to show the status bar with navigation bar buttons without overlaps.
If gallery is showed with visible status bar the navigation buttons overlaps it, with this small change you can set to move content origin under status bar to prevent it.

Before:

After:

Code:

private class PhotosViewController: NYTPhotosViewController {
    override var prefersStatusBarHidden: Bool {
        return false
    }
    
    override var preferredStatusBarStyle: UIStatusBarStyle {
        return .lightContent
    }
}

let viewer = PhotosViewController(photos: [photo], initialPhoto: photo, delegate: nil)
viewer.underStatusBar = true
self.present(viewer, animated: true, completion: nil)

[livings124]

A version of this that only shows the status bar when the chrome is shown would be great. I might take my hand at it if you don't want to include it here.

[scottcc]

+1 for this. Had issues when dismissing the NYTPhotosViewController, the now-shown VC would have things overlapping, no matter what setNeedsStatusBarUpdate/NeedsLayout/NeedsWhatever was called. Moved my Podfile pointer to your commit, no more problems. Nicely done!

[justColbs]

@scottcc Could you show me what that line in your Podfile looked like? It's giving me issues. Thanks!

[scottcc]

Sure:
pod 'NYTPhotoViewer', :git => 'https://github.com/sergiog90/NYTPhotoViewer.git', commit: '06da6a02151cc5c28adddd77c9d729c7a103ac48'

[Huang-Libo]

+1

[benguild]

Anybody else seeing the content jump downward the height of the status bar to accommodate after the modal finishes transitioning in?

[benguild]

@sergiog90 Regarding my prior comment from about an hour ago, I found that the animations are no longer offset/broken between view and modal if you leave the pageViewController as-is:

self.pageViewController.view.frame = self.view.bounds; // frame;

That way, the photo remains centered on the screen, but the navigation bar isn't clipping the status bar?

Does this look OK to you, or break something that you were intending to change? I think maybe it's best to update your branch if fine.

[mr-fixit]

a belated thanks for this submission @sergiog90!

i'm closing this PR in favor of #336.

[BenderNK]

neither this nor the referenced #336 pull request has been merged as of this writing. 😢