Address tickets within the scope of NYS-184 accessibility mini-audit #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NYS-191: Search input is missing an associated label - NYS-193: mobile menu button is missing an accessible name - NYS-196: Missing form label for tab inputs - NYS-197: incorrect semantics for tabs - NYS-201: Load More link does not announce to a screen reader user that more is now showing on the page - NYS-203: select dropdown missing associated label - NYS-205: Select filters missing associated label - NYS-206: Date input missing associated label - NYS-208: incorrect use of labels - NYS-215: select dropdowns are missing an associated label - NYS-230: Gaining keyboard focus on the search makes everything move - NYS-233: the Main `nav` needs to have an accessible name for screen readers - NYS-234: Mobile menu does not have proper semantics for screen readers - NYS-235: Mobile menu should close with "Esc" key - Ad hoc fix to implement proper dependency injection in global search
nathanielwoodland
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
The code changes look good to me! Of course, Michaela's review is the real hurdle here, as I can't verify things from that POV.
Side note: I personally might've shied away from the code consolidation logic in block-content--tabs.html.twig, and instead kept things dumb simple (emphasis on dumb), as I hate (aka I suck at) debugging TWIG when things break. But YMMV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navneeds to have an accessible name for screen readers