Skip checksum when download file failed.

[Buguin]

Fixes #3075
Check if the file is successfully downloaded

[ljharb]

@Buguin are you still interested in completing this PR?

[Buguin]

@Buguin are you still interested in completing this PR?

Sorry，I'm too busy working this time. Recently, I will make a push to solve the problem of not being able to return when an error is reported in the following code.

nvm_err "Downloading ${TARBALL_URL}..."
  nvm_download -L -C - "${PROGRESS_BAR}" "${TARBALL_URL}" -o "${TARBALL}" || (
    command rm -rf "${TARBALL}" "${tmpdir}"
    nvm_err "Binary download from ${TARBALL_URL} failed, trying source."
    return 4---it does not work, function not return.
  )

[Buguin]

@Buguin are you still interested in completing this PR?

I have transformed nvm_download_artifact function, which allows you to determine the download status based on the execution results.

[ljharb]

i think we don't want to print this in the common success case, and probably not even in the error case. You can, however, wrap it in a NVM_DEBUG check for debugging:

Suggested change

	nvm_err "Download Http Status ${download_result}"
	if [ "${NVM_DEBUG-}" = 1 ]; then
	nvm_err "Download Http Status ${download_result}"
	fi

[ljharb]

This is looking great! Can you come up with some unit tests (one that mocks out nvm_download and tests nvm_download_artifact, and another that mocks out curl/wget and tests nvm_download)?

[ljharb]

I've rebased this, but it still needs tests. @Buguin any chance you're still interesting in completing this PR?