feat: add many icons

[hasecilu]

Still WIP I'm looking at more icons, I want to hear some ideas.
Also I'm waiting for new Nerd Fonts release that includes some new icons. 3.2.0 ver. released, I included the KDE, posmarketOS & Qt logos that are new.

https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.2.0

---

For example in:

local filetypes = {
  ["avif"] = "avif",
  ["bzl"] = "bzl",
...
}

Would be possible to create groups, for example create a single icon entry and use it various times for different file extensions to simplify the code? For example the open PR with music extensions, maybe a group of video, compressed files. In my case in this PR check the FreeCAD and KiCad extensions.

Something like:

local filetypes = {
...
  ["fcmacro"] = "freecad",
  ["fcmat"] = "freecad",
  ["fcparam"] = "freecad",
  ["fcstd"] = "freecad",
...
}

[hasecilu]

Rebased, I think now only need to update local filetypes = {}

[alex-courtis]

Looking good...

Some of the darks ones are... too dark to see.

XTerm.vt100.reverseVideo:	true
XTerm.termName:	xterm-256color

XTerm.vt100.reverseVideo:	true
XTerm.termName:	xterm-direct

I encountered the same with linux and fixed them here: #408

I just poked around the website until I found another theme colour that was more dark friendly.

[alex-courtis]

Fails at startup when using xterm defaults i.e. nothing in xrdb. Master is OK.

xterm -rv is OK.

Error detected while processing VimEnter Autocommands for "*":
E5108: Error executing lua [string ":lua"]:1: VimEnter Autocommands for "*"..OptionSet Autocommands for "background": Vim(append):Error executing lua callback: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_extend'
        ...ite/pack/packer/start/hasecilu/lua/nvim-web-devicons.lua:39: in function 'refresh_icons'
        ...ite/pack/packer/start/hasecilu/lua/nvim-web-devicons.lua:567: in function <...ite/pack/packer/start/hasecilu/lua/nvim-web-devicons.lua:566>
        [C]: in function '__newindex'
        [string ":lua"]:1: in main chunk
stack traceback:
        [C]: in function '__newindex'
        [string ":lua"]:1: in main chunk
Press ENTER or type command to continue

[alex-courtis]

This is looking really good!

There are two unrelated changes here: adding the two new classes of icons and adding new icons. Let's split into two PRs please.

• split into PRs: new categories and new icons
• fix the dark icons feat: add many icons #433 (comment)
• fix the strange xterm error feat: add many icons #433 (comment)

[hasecilu]

I was about to update local filetypes = {} but I noticed that a lot of extensions are missing and even some don't appear in the table as "dosbatch", what's the diffenrence for filetype and file extension?

[alex-courtis]

what's the diffenrence for filetype and file extension?

It's just a mapping of vim filetypes to something - extension, name, os

It's not well maintained.

[alex-courtis]

Looking good so far, only small nits.

My concentration is flagging now. I'll look at the rest tomorrow.

[alex-courtis]

• fix the strange xterm error feat: add more icon asociations, mainly from font-logos #433 (comment)

This is working now. Everything is following existing patterns so not worth digging deeper...

[alex-courtis]

Review complete, small changes only.

Please don't resolve conversations. I'll do that so that I can review and mark the subsequent changes.

Edit: please lighten

• gcode
• xpi
• archlabs

[hasecilu]

More changes, let me know if something is missing

[alex-courtis]

There are some vim filetype mappings we can add e.g. gtkrc

Can you please look through /usr/share/nvim/runtime/syntax and find any others to map?

[hasecilu]

Sure, maybe an instruction to redirect to /usr/share/nvim/runtime/syntax would be useful

[alex-courtis]

Sure, maybe an instruction to redirect to /usr/share/nvim/runtime/syntax would be useful

Sorry, I mean add them to

-- Map of filetypes -> icon names
local filetypes = {
  ["avif"] = "avif",

[hasecilu]

What I meant it was to put an instructions for contributors that doesn't know of the existance of those files, like me 😅
I used this to find coincidences:

lua_file="$HOME/git/github/nvim-web-devicons/lua/nvim-web-devicons/icons-default.lua"
ft="$HOME/git/github/nvim-web-devicons/lua/nvim-web-devicons.lua"
while IFS= read -r line; do
if [[ $line =~ \[\"(.+)\"\] ]]; then
	key="${BASH_REMATCH[1]}"
	# Search for the key in the main file
	line=$(grep -F "\"$key\"" "$ft")
	if [ -n "$line" ]; then
		continue
	else
		# echo "$key" | lolcat
		[ -f "/usr/share/nvim/runtime/syntax/$key.vim" ] && echo "$key.vim"
	fi
fi
done <"$lua_file"

[alex-courtis]

What I meant it was to put an instructions for contributors that doesn't know of the existance of those files, like me 😅 I used this to find coincidences:

lua_file="$HOME/git/github/nvim-web-devicons/lua/nvim-web-devicons/icons-default.lua"
ft="$HOME/git/github/nvim-web-devicons/lua/nvim-web-devicons.lua"
while IFS= read -r line; do
if [[ $line =~ \[\"(.+)\"\] ]]; then
	key="${BASH_REMATCH[1]}"
	# Search for the key in the main file
	line=$(grep -F "\"$key\"" "$ft")
	if [ -n "$line" ]; then
		continue
	else
		# echo "$key" | lolcat
		[ -f "/usr/share/nvim/runtime/syntax/$key.vim" ] && echo "$key.vim"
	fi
fi
done <"$lua_file"

Oh nice. Maybe drop it in scripts. There's an existing one but it doesn't seem to be very useful.

[alex-courtis]

Many thanks for this outstanding contribution!

Next time please, please smaller PRs.