fix(#2954): resolve occasional tree flashing on diagnostics, set tree buffer options in deterministic order #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures related autocmd's (e.g. on FileType) will be called in a similar environment.
…'buflisted' is_buf_valid has been inlined since it is only used for diagnostics and its name is misleading.
des-b
changed the title
alex-courtis
changed the title
alex-courtis
approved these changes
Nov 2, 2024
des-b
added a commit
that referenced
this pull request
Nov 10, 2024
This ensures that LSP diagnostics of files which are not manually opened by users are rendered by nvim-tree diagnostic indicators. However when users attach an LSP to nvim-tree this will bring back flashing as attempted to fix in #2980. Fixing this should probably done by checking data passed via diagnostic events (DiagnosticChanged and CocDiagnosticChanged). Signed-off-by: des-b <[email protected]>
alex-courtis
pushed a commit
that referenced
this pull request
Nov 10, 2024
…() (#2998) This ensures that LSP diagnostics of files which are not manually opened by users are rendered by nvim-tree diagnostic indicators. However when users attach an LSP to nvim-tree this will bring back flashing as attempted to fix in #2980. Fixing this should probably done by checking data passed via diagnostic events (DiagnosticChanged and CocDiagnosticChanged). Signed-off-by: des-b <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2954