chore: resolve undefined-field warnings, fix link git statuses, rewrite devicons #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, *_git_status (#2944) * extract DirectoryLinkNode and FileLinkNode, move Node methods to children * temporarily move DirectoryNode methods into BaseNode for easier reviewing * move mostly unchanged DirectoryNode methods back to BaseNode * tidy * git.git_status_file takes an array * update git status of links * luacheck hack
…e:expand_or_collapse (#2957) move expand_or_collapse to DirectoryNode
) * move last_group_node to DirectoryNode * move add BaseNode:as and more doc * revert parameter name changes * revert parameter name changes * add Class * move group methods into DN * tidy group methods * tidy group methods * tidy group methods * tidy group methods * parent is DirectoryNode * tidy expand all * BaseNode -> Node * move watcher to DirectoryNode * last_group_node is DirectoryNode only * simplify create-file * simplify parent * simplify collapse-all * simplify live-filter * style
This reverts commit be546ff.
alex-courtis
force-pushed
the
chore-undefined-field
branch
from
6e0ec58
to
ab4f769
Compare
alex-courtis
changed the base branch from
master
to
2941-move-lib-to-explorer
This reverts commit 0e9b844.
|
Icon testing master vs branch: -- main components
local icon, name = node:highlighted_icon(), node:highlighted_name()
log.raw("dev", "%s icon=%s name=%s\n", node.name, vim.inspect(icon, { newline = "" }), vim.inspect(name, { newline = "" }))vim.keymap.set("n", "<space>t", function()
local explorer = core.get_explorer()
log.raw("dev", "\nexplorer.opts.renderer.icons.show.folder = false\n")
explorer.opts.renderer.icons.show.folder = false
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.show.folder = true\n")
explorer.opts.renderer.icons.show.folder = true
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.web_devicons.folder.enable = true\n")
explorer.opts.renderer.icons.web_devicons.folder.enable = true
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.web_devicons.folder.color = false\n")
explorer.opts.renderer.icons.web_devicons.folder.color = false
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.web_devicons.file.color = false\n")
explorer.opts.renderer.icons.web_devicons.file.color = false
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.web_devicons.file.enable = false\n")
explorer.opts.renderer.icons.web_devicons.file.enable = false
api.tree.reload()
log.raw("dev", "\ndevicons.default_icon = nil\n")
devicons.default_icon = nil
api.tree.reload()
log.raw("dev", "\nicons.devicons = nil\n")
icons.devicons = nil
pcall(icons, reset_config)
api.tree.reload()
log.raw("dev", "\nexplorer.opts.renderer.icons.show.file = false\n")
explorer.opts.renderer.icons.show.file = false
api.tree.reload()
log.raw("dev", "\napi.tree.expand_all()\n")
api.tree.expand_all()
log.raw("dev", "\nexplorer.opts.renderer.icons.show.folder = false\n")
explorer.opts.renderer.icons.show.folder = false
api.tree.reload()
end, { noremap = true })Fixed typo on master: local function get_folder_icon_default(node, has_children)
local is_symlink = node.links_to ~= nilBranch now does not show file link icon when Master used |
alex-courtis
changed the title
alex-courtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves most undefined-field warnings however not enabled.
todo, subsequent PR:
Dogfooding ~1 week
Includes fixes from #2983