Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul #2639

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Jan 22, 2024

This is a break however it is needed. The normalised highlight groups brought them too close together.

Git groups could do with some disambiguation however there are no standards. We could bring them in line with gitsigns and lualine however that may be too much of a breaking change.

With default dark scheme:

  • root: purple->bold purple (Title)
  • modified: dark brown->green (Type)
  • opened: dark brown->light brow (Special)
  • bookmark icon: dark brown->folder icon
  • specials: ->blue undercurl (SpellCap)

Added more documentation.

@alex-courtis alex-courtis merged commit d9cb432 into master Jan 29, 2024
4 checks passed
@alex-courtis alex-courtis deleted the 2415-disambiguate branch January 29, 2024 01:43
juefeiyan pushed a commit to juefeiyan/nvim-tree.lua that referenced this pull request Jan 30, 2024
…ee-highlight-overhaul (nvim-tree#2639)

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul

* fix(nvim-tree#2415): disambiguate highlight groups, see :help nvim-tree-highlight-overhaul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant